DO NOT SUBMIT: Switch to deny-by-default for crater

Author: ia0

src/libcore/tests/ascii.rs

@@ -151,7 +151,7 @@ macro_rules! assert_none {
                            stringify!($what), b);
                 }
             }
-        )*
+        )+
     }};
     ($what:ident, $($str:tt),+,) => (assert_none!($what,$($str),+))
 }

src/libcore/tests/pattern.rs

@@ -5,7 +5,7 @@ use std::str::pattern::*;
 macro_rules! search_asserts {
     ($haystack:expr, $needle:expr, $testname:expr, [$($func:ident),*], $result:expr) => {
         let mut searcher = $needle.into_searcher($haystack);
-        let arr = [$( Step::from(searcher.$func()) ),+];
+        let arr = [$( Step::from(searcher.$func()) ),*];
         assert_eq!(&arr[..], &$result, $testname);
     }
 }

src/librustc/lint/builtin.rs

@@ -356,7 +356,7 @@ pub mod parser {
 
     declare_lint! {
         pub META_VARIABLE_MISUSE,
-        Allow,
+        Deny,
         "possible meta-variable misuse at macro definition"
     }
 }

src/test/ui/issues/issue-6596-1.rs

@@ -1,6 +1,6 @@
 macro_rules! e {
     ($inp:ident) => (
-        $nonexistent
+        $nonexistent //~ ERROR unknown macro variable `nonexistent`
         //~^ ERROR unknown macro variable `nonexistent`
     );
 }

src/test/ui/issues/issue-6596-1.stderr

@@ -7,5 +7,13 @@ LL |         $nonexistent
 LL |     e!(foo);
    |     -------- in this macro invocation
 
-error: aborting due to previous error
+error: unknown macro variable `nonexistent`
+  --> $DIR/issue-6596-1.rs:3:9
+   |
+LL |         $nonexistent
+   |         ^^^^^^^^^^^^
+   |
+   = note: #[deny(meta_variable_misuse)] on by default
+
+error: aborting due to 2 previous errors
 

src/test/ui/issues/issue-6596-2.rs

@@ -2,7 +2,7 @@
 
 macro_rules! g {
     ($inp:ident) => (
-        { $inp $nonexistent }
+        { $inp $nonexistent } //~ ERROR unknown macro variable `nonexistent`
         //~^ ERROR unknown macro variable `nonexistent`
     );
 }

src/test/ui/issues/issue-6596-2.stderr

@@ -7,5 +7,13 @@ LL |         { $inp $nonexistent }
 LL |     g!(foo);
    |     -------- in this macro invocation
 
-error: aborting due to previous error
+error: unknown macro variable `nonexistent`
+  --> $DIR/issue-6596-2.rs:5:16
+   |
+LL |         { $inp $nonexistent }
+   |                ^^^^^^^^^^^^
+   |
+   = note: #[deny(meta_variable_misuse)] on by default
+
+error: aborting due to 2 previous errors