returns immediately on references error

csmoe · csmoe · commit 7da72056cf71 · 2018-09-06T10:15:58.000+08:00
diff --git a/src/librustc_mir/borrow_check/nll/type_check/mod.rs b/src/librustc_mir/borrow_check/nll/type_check/mod.rs
@@ -415,10 +415,9 @@ impl<'a, 'b, 'gcx, 'tcx> TypeVerifier<'a, 'b, 'gcx, 'tcx> {
             if let PlaceTy::Ty { ty } = place_ty {
                 if ty.references_error() {
                     assert!(self.errors_reported);
-                    place_ty = PlaceTy::Ty {
+                    return PlaceTy::Ty {
                         ty: self.tcx().types.err,
                     };
-                    break;
                 }
             }
             place_ty = self.sanitize_projection(place_ty, elem, place, location);

Original file line number	Diff line number	Diff line change
`@@ -415,10 +415,9 @@ impl<'a, 'b, 'gcx, 'tcx> TypeVerifier<'a, 'b, 'gcx, 'tcx> {`
`415`	`415`	`if let PlaceTy::Ty { ty } = place_ty {`
`416`	`416`	`if ty.references_error() {`
`417`	`417`	`assert!(self.errors_reported);`
`418`		`- place_ty = PlaceTy::Ty {`
	`418`	`+ return PlaceTy::Ty {`
`419`	`419`	`ty: self.tcx().types.err,`
`420`	`420`	`};`
`421`		`- break;`
`422`	`421`	`}`
`423`	`422`	`}`
`424`	`423`	`place_ty = self.sanitize_projection(place_ty, elem, place, location);`