Skip to content

Commit 7a4d071

Browse files
author
bing
committed
Less authoritative stable_sort_primitive message
1 parent e5ebece commit 7a4d071

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

clippy_lints/src/stable_sort_primitive.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ declare_clippy_lint! {
3030
/// ```
3131
#[clippy::version = "1.47.0"]
3232
pub STABLE_SORT_PRIMITIVE,
33-
perf,
33+
pedantic,
3434
"use of sort() when sort_unstable() is equivalent"
3535
}
3636

@@ -126,7 +126,7 @@ impl LateLintPass<'_> for StableSortPrimitive {
126126
Applicability::MachineApplicable,
127127
);
128128
diag.note(
129-
"an unstable sort would perform faster without any observable difference for this data type",
129+
"an unstable sort typically performs faster without any observable difference for this data type",
130130
);
131131
},
132132
);

tests/ui/stable_sort_primitive.stderr

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,55 +5,55 @@ LL | vec.sort();
55
| ^^^^^^^^^^ help: try: `vec.sort_unstable()`
66
|
77
= note: `-D clippy::stable-sort-primitive` implied by `-D warnings`
8-
= note: an unstable sort would perform faster without any observable difference for this data type
8+
= note: an unstable sort typically performs faster without any observable difference for this data type
99

1010
error: used `sort` on primitive type `bool`
1111
--> $DIR/stable_sort_primitive.rs:9:5
1212
|
1313
LL | vec.sort();
1414
| ^^^^^^^^^^ help: try: `vec.sort_unstable()`
1515
|
16-
= note: an unstable sort would perform faster without any observable difference for this data type
16+
= note: an unstable sort typically performs faster without any observable difference for this data type
1717

1818
error: used `sort` on primitive type `char`
1919
--> $DIR/stable_sort_primitive.rs:11:5
2020
|
2121
LL | vec.sort();
2222
| ^^^^^^^^^^ help: try: `vec.sort_unstable()`
2323
|
24-
= note: an unstable sort would perform faster without any observable difference for this data type
24+
= note: an unstable sort typically performs faster without any observable difference for this data type
2525

2626
error: used `sort` on primitive type `str`
2727
--> $DIR/stable_sort_primitive.rs:13:5
2828
|
2929
LL | vec.sort();
3030
| ^^^^^^^^^^ help: try: `vec.sort_unstable()`
3131
|
32-
= note: an unstable sort would perform faster without any observable difference for this data type
32+
= note: an unstable sort typically performs faster without any observable difference for this data type
3333

3434
error: used `sort` on primitive type `tuple`
3535
--> $DIR/stable_sort_primitive.rs:15:5
3636
|
3737
LL | vec.sort();
3838
| ^^^^^^^^^^ help: try: `vec.sort_unstable()`
3939
|
40-
= note: an unstable sort would perform faster without any observable difference for this data type
40+
= note: an unstable sort typically performs faster without any observable difference for this data type
4141

4242
error: used `sort` on primitive type `array`
4343
--> $DIR/stable_sort_primitive.rs:17:5
4444
|
4545
LL | vec.sort();
4646
| ^^^^^^^^^^ help: try: `vec.sort_unstable()`
4747
|
48-
= note: an unstable sort would perform faster without any observable difference for this data type
48+
= note: an unstable sort typically performs faster without any observable difference for this data type
4949

5050
error: used `sort` on primitive type `i32`
5151
--> $DIR/stable_sort_primitive.rs:19:5
5252
|
5353
LL | arr.sort();
5454
| ^^^^^^^^^^ help: try: `arr.sort_unstable()`
5555
|
56-
= note: an unstable sort would perform faster without any observable difference for this data type
56+
= note: an unstable sort typically performs faster without any observable difference for this data type
5757

5858
error: aborting due to 7 previous errors
5959

0 commit comments

Comments
 (0)