Skip to content

Commit 7935e87

Browse files
committed
leave a note about maybe delaying an error message
1 parent 2860b75 commit 7935e87

File tree

1 file changed

+2
-9
lines changed
  • compiler/rustc_builtin_macros/src

1 file changed

+2
-9
lines changed

compiler/rustc_builtin_macros/src/asm.rs

+2-9
Original file line numberDiff line numberDiff line change
@@ -353,15 +353,7 @@ pub fn validate_raw_asm_args<'a>(
353353

354354
for (symbol, option, span, full_span) in new_options {
355355
if !asm_macro.is_supported_option(option) {
356-
/*
357-
// Tool-only output
358-
p.dcx().emit_err(errors::AsmUnsupportedOption {
359-
span,
360-
symbol,
361-
full_span,
362-
macro_name: asm_macro.macro_name(),
363-
});
364-
*/
356+
// Currently handled during parsing.
365357
} else if args.options.contains(option) {
366358
// Tool-only output
367359
dcx.emit_err(errors::AsmOptAlreadyprovided { span, symbol, full_span });
@@ -506,6 +498,7 @@ fn parse_options<'a>(
506498
let full_span =
507499
if p.token == token::Comma { span.to(p.token.span) } else { span };
508500

501+
// NOTE: should this be handled during validation instead?
509502
if !asm_macro.is_supported_option(option) {
510503
// Tool-only output
511504
p.dcx().emit_err(errors::AsmUnsupportedOption {

0 commit comments

Comments
 (0)