Skip to content

Commit 6f7dea7

Browse files
scottmcmlcnr
andauthored
Mention the issue number for the new mir-opt in the FIXMEs
Thanks for the suggestions, lcnr! Co-authored-by: lcnr <[email protected]>
1 parent bf0e34c commit 6f7dea7

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/test/codegen/try_identity.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ type R = Result<u64, i32>;
99

1010
// This was written to the `?` from `try_trait`, but `try_trait_v2` uses a different structure,
1111
// so the relevant desugar is copied inline in order to keep the test testing the same thing.
12-
// FIXME: while this might be useful for `r#try!`, it would be nice to have a MIR optimization
12+
// FIXME(#85133): while this might be useful for `r#try!`, it would be nice to have a MIR optimization
1313
// that picks up the `?` desugaring, as `SimplifyArmIdentity` does not. See #85133
1414
#[no_mangle]
1515
pub fn try_identity(x: R) -> R {

src/test/mir-opt/simplify-arm.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ fn from_error<T, E>(e: E) -> Result<T, E> {
3030

3131
// This was written to the `?` from `try_trait`, but `try_trait_v2` uses a different structure,
3232
// so the relevant desugar is copied inline in order to keep the test testing the same thing.
33-
// FIXME: while this might be useful for `r#try!`, it would be nice to have a MIR optimization
33+
// FIXME(#85133): while this might be useful for `r#try!`, it would be nice to have a MIR optimization
3434
// that picks up the `?` desugaring, as `SimplifyArmIdentity` does not. See #85133
3535
fn id_try(r: Result<u8, i32>) -> Result<u8, i32> {
3636
let x = match into_result(r) {

src/test/mir-opt/simplify_try.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ fn from_error<T, E>(e: E) -> Result<T, E> {
1515

1616
// This was written to the `?` from `try_trait`, but `try_trait_v2` uses a different structure,
1717
// so the relevant desugar is copied inline in order to keep the test testing the same thing.
18-
// FIXME: while this might be useful for `r#try!`, it would be nice to have a MIR optimization
18+
// FIXME(#85133): while this might be useful for `r#try!`, it would be nice to have a MIR optimization
1919
// that picks up the `?` desugaring, as `SimplifyArmIdentity` does not. See #85133
2020
fn try_identity(x: Result<u32, i32>) -> Result<u32, i32> {
2121
let y = match into_result(x) {

0 commit comments

Comments
 (0)