File tree 1 file changed +11
-4
lines changed
src/test/run-make-fulldeps
1 file changed +11
-4
lines changed Original file line number Diff line number Diff line change @@ -21,11 +21,18 @@ CGREP := "$(S)/src/etc/cat-and-grep.sh"
21
21
# diff with common flags for multi-platform diffs against text output
22
22
DIFF := diff -u --strip-trailing-cr
23
23
24
- # CI platforms use `/bin/dash`. When compiling in other environments, the
25
- # default may be different (for example, may default to `/bin/bash`), and syntax
26
- # and results could be different. Ensure Makefile `$(shell ...)` invocations
27
- # always run in `dash`.
24
+ # Some of the Rust CI platforms use `/bin/dash` to run `shell` script in
25
+ # Makefiles. Other platforms, including many developer platforms, default to
26
+ # `/bin/bash`. (In many cases, `make` is actually using `/bin/sh`, but `sh`
27
+ # is configured to execute one or the other shell binary). `dash` features
28
+ # support only a small subset of `bash` features, so `dash` can be thought of as
29
+ # the lowest common denominator, and tests should be validated against `dash`
30
+ # whenever possible. Most developer platforms include `/bin/dash`, but to ensure
31
+ # tests still work when `/bin/dash`, if not available, this `SHELL` override is
32
+ # conditional:
33
+ ifneq (,$(wildcard /bin/dash) )
28
34
SHELL := /bin/dash
35
+ endif
29
36
30
37
# This is the name of the binary we will generate and run; use this
31
38
# e.g. for `$(CC) -o $(RUN_BINFILE)`.
You can’t perform that action at this time.
0 commit comments