ensure that aarch64 hardfloat targets do not disable neon or fp-armv8

Author: RalfJung

compiler/rustc_target/src/spec/mod.rs

@@ -2593,6 +2593,18 @@ impl TargetOptions {
                 .collect();
         }
     }
+
+    pub(crate) fn has_neg_feature(&self, search_feature: &str) -> bool {
+        self.features.split(',').any(|f| {
+            if let Some(f) = f.strip_prefix('-')
+                && f == search_feature
+            {
+                true
+            } else {
+                false
+            }
+        })
+    }
 }
 
 impl Default for TargetOptions {
@@ -3108,6 +3120,15 @@ impl Target {
             _ => {}
         }
 
+        // Check that aarch64 hardfloat targets do not disable neon or fp-armv8 (which are
+        // on-by-default).
+        if self.arch == "aarch64" && self.abi != "softfloat" {
+            check!(
+                !self.has_neg_feature("neon") && !self.has_neg_feature("fp-armv8"),
+                "aarch64 hardfloat targets must not disable the `neon` or `fp-armv8` target features"
+            );
+        }
+
         Ok(())
     }