Stabilize #[cfg(version(...))]

Author: est31

compiler/rustc_feature/src/accepted.rs

@@ -107,6 +107,8 @@ declare_features! (
     (accepted, cfg_target_feature, "1.27.0", Some(29717)),
     /// Allows `cfg(target_vendor = "...")`.
     (accepted, cfg_target_vendor, "1.33.0", Some(29718)),
+    /// Allow conditional compilation depending on rust version
+    (accepted, cfg_version, "CURRENT_RUSTC_VERSION", Some(64796)),
     /// Allows implementing `Clone` for closures where possible (RFC 2132).
     (accepted, clone_closures, "1.26.0", Some(44490)),
     /// Allows coercing non capturing closures to function pointers.

compiler/rustc_feature/src/builtin_attrs.rs

@@ -33,7 +33,6 @@ const GATED_CFGS: &[GatedCfg] = &[
         Features::cfg_target_has_atomic,
     ),
     (sym::sanitize, sym::cfg_sanitize, Features::cfg_sanitize),
-    (sym::version, sym::cfg_version, Features::cfg_version),
     (sym::relocation_model, sym::cfg_relocation_model, Features::cfg_relocation_model),
     (sym::sanitizer_cfi_generalize_pointers, sym::cfg_sanitizer_cfi, Features::cfg_sanitizer_cfi),
     (sym::sanitizer_cfi_normalize_integers, sym::cfg_sanitizer_cfi, Features::cfg_sanitizer_cfi),

compiler/rustc_feature/src/unstable.rs

@@ -418,8 +418,6 @@ declare_features! (
     (unstable, cfg_target_thread_local, "1.7.0", Some(29594)),
     /// Allows the use of `#[cfg(ub_checks)` to check if UB checks are enabled.
     (unstable, cfg_ub_checks, "1.79.0", Some(123499)),
-    /// Allow conditional compilation depending on rust version
-    (unstable, cfg_version, "1.45.0", Some(64796)),
     /// Allows to use the `#[cfi_encoding = ""]` attribute.
     (unstable, cfi_encoding, "1.71.0", Some(89653)),
     /// Allows `for<...>` on closures and coroutines.

tests/ui/feature-gates/feature-gate-cfg-version.rs renamed to tests/ui/cfg/cfg-version/cfg-version.rs

@@ -1,49 +1,35 @@
 #[cfg(version(42))] //~ ERROR: expected a version literal
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn foo() {}
 #[cfg(version(1.20))] //~ ERROR: expected a version literal
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn foo() -> bool { true }
 #[cfg(version("1.44"))]
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn foo() -> bool { true }
 #[cfg(not(version("1.44")))]
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn foo() -> bool { false }
 
 #[cfg(version("1.43", "1.44", "1.45"))] //~ ERROR: expected single version literal
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool  { false }
 #[cfg(version(false))] //~ ERROR: expected a version literal
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool  { false }
 #[cfg(version("foo"))] //~ WARNING: unknown version literal format
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool  { false }
 #[cfg(version("999"))] //~ WARNING: unknown version literal format
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool  { false }
 #[cfg(version("-1"))] //~ WARNING: unknown version literal format
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool  { false }
 #[cfg(version("65536"))] //~ WARNING: unknown version literal format
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool  { false }
 #[cfg(version("0"))] //~ WARNING: unknown version literal format
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool { true }
 #[cfg(version("1.0"))]
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool { true }
 #[cfg(version("1.65536.2"))] //~ WARNING: unknown version literal format
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() -> bool  { false }
 #[cfg(version("1.20.0-stable"))] //~ WARNING: unknown version literal format
-//~^ ERROR `cfg(version)` is experimental and subject to change
 fn bar() {}
 
 fn main() {
     assert!(foo());
     assert!(bar());
-    assert!(cfg!(version("1.42"))); //~ ERROR `cfg(version)` is experimental and subject to change
+    assert!(cfg!(version("1.42")));
 }

tests/ui/cfg/cfg-version/cfg-version.stderr

@@ -0,0 +1,68 @@
+error: expected a version literal
+  --> $DIR/cfg-version.rs:1:15
+   |
+LL | #[cfg(version(42))]
+   |               ^^
+
+error: expected a version literal
+  --> $DIR/cfg-version.rs:3:15
+   |
+LL | #[cfg(version(1.20))]
+   |               ^^^^
+
+error: expected single version literal
+  --> $DIR/cfg-version.rs:10:7
+   |
+LL | #[cfg(version("1.43", "1.44", "1.45"))]
+   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: expected a version literal
+  --> $DIR/cfg-version.rs:12:15
+   |
+LL | #[cfg(version(false))]
+   |               ^^^^^
+
+warning: unknown version literal format, assuming it refers to a future version
+  --> $DIR/cfg-version.rs:14:15
+   |
+LL | #[cfg(version("foo"))]
+   |               ^^^^^
+
+warning: unknown version literal format, assuming it refers to a future version
+  --> $DIR/cfg-version.rs:16:15
+   |
+LL | #[cfg(version("999"))]
+   |               ^^^^^
+
+warning: unknown version literal format, assuming it refers to a future version
+  --> $DIR/cfg-version.rs:18:15
+   |
+LL | #[cfg(version("-1"))]
+   |               ^^^^
+
+warning: unknown version literal format, assuming it refers to a future version
+  --> $DIR/cfg-version.rs:20:15
+   |
+LL | #[cfg(version("65536"))]
+   |               ^^^^^^^
+
+warning: unknown version literal format, assuming it refers to a future version
+  --> $DIR/cfg-version.rs:22:15
+   |
+LL | #[cfg(version("0"))]
+   |               ^^^
+
+warning: unknown version literal format, assuming it refers to a future version
+  --> $DIR/cfg-version.rs:26:15
+   |
+LL | #[cfg(version("1.65536.2"))]
+   |               ^^^^^^^^^^^
+
+warning: unknown version literal format, assuming it refers to a future version
+  --> $DIR/cfg-version.rs:28:15
+   |
+LL | #[cfg(version("1.20.0-stable"))]
+   |               ^^^^^^^^^^^^^^^
+
+error: aborting due to 4 previous errors; 7 warnings emitted
+