Skip to content

Commit 1751802

Browse files
committed
Unify walk_mac_call
1 parent 4673554 commit 1751802

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

compiler/rustc_ast/src/visitors.rs

+11-12
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ macro_rules! make_ast_visitor {
333333
make_visit!{Label; visit_label, walk_label}
334334
make_visit!{Lifetime, _ ctxt: LifetimeCtxt; visit_lifetime, walk_lifetime}
335335
make_visit!{Local; visit_local, walk_local}
336-
make_visit!{MacCall; visit_mac_call, walk_mac}
336+
make_visit!{MacCall; visit_mac_call, walk_mac_call}
337337
make_visit!{MutTy; visit_mt, walk_mt}
338338
make_visit!{Option<P<QSelf>>; visit_qself, walk_qself}
339339
make_visit!{Param; visit_param, walk_param}
@@ -770,6 +770,16 @@ macro_rules! make_ast_visitor {
770770
return_result!(V)
771771
}
772772

773+
pub fn walk_mac_call<$($lt,)? V: $trait$(<$lt>)?>(
774+
vis: &mut V,
775+
mac: ref_t!(MacCall)
776+
) -> result!(V) {
777+
let MacCall { path, args } = mac;
778+
try_v!(vis.visit_path(path, DUMMY_NODE_ID));
779+
visit_delim_args!(vis, args);
780+
return_result!(V)
781+
}
782+
773783
pub fn walk_mt<$($lt,)? V: $trait$(<$lt>)?>(
774784
vis: &mut V,
775785
mt: ref_t!(MutTy)
@@ -1538,11 +1548,6 @@ pub mod visit {
15381548
V::Result::output()
15391549
}
15401550

1541-
pub fn walk_mac<'a, V: Visitor<'a>>(visitor: &mut V, mac: &'a MacCall) -> V::Result {
1542-
let MacCall { path, args: _ } = mac;
1543-
visitor.visit_path(path, DUMMY_NODE_ID)
1544-
}
1545-
15461551
pub fn walk_expr<'a, V: Visitor<'a>>(visitor: &mut V, expression: &'a Expr) -> V::Result {
15471552
let Expr { id, kind, span, attrs, tokens: _ } = expression;
15481553
walk_list!(visitor, visit_attribute, attrs);
@@ -1873,12 +1878,6 @@ pub mod mut_visit {
18731878
vis.visit_span(span);
18741879
}
18751880

1876-
fn walk_mac<T: MutVisitor>(vis: &mut T, mac: &mut MacCall) {
1877-
let MacCall { path, args } = mac;
1878-
vis.visit_path(path, DUMMY_NODE_ID);
1879-
visit_delim_args(vis, args);
1880-
}
1881-
18821881
fn walk_macro_def<T: MutVisitor>(vis: &mut T, macro_def: &mut MacroDef) {
18831882
let MacroDef { body, macro_rules: _ } = macro_def;
18841883
visit_delim_args(vis, body);

compiler/rustc_ast_passes/src/node_count.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ impl<'ast> Visitor<'ast> for NodeCounter {
105105
}
106106
fn visit_mac_call(&mut self, mac: &MacCall) {
107107
self.count += 1;
108-
walk_mac(self, mac)
108+
walk_mac_call(self, mac)
109109
}
110110
fn visit_path(&mut self, path: &Path, _id: NodeId) {
111111
self.count += 1;

compiler/rustc_lint/src/early.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ impl<'a, T: EarlyLintPass> ast_visit::Visitor<'a> for EarlyContextAndPass<'a, T>
296296

297297
fn visit_mac_call(&mut self, mac: &'a ast::MacCall) {
298298
lint_callback!(self, check_mac, mac);
299-
ast_visit::walk_mac(self, mac);
299+
ast_visit::walk_mac_call(self, mac);
300300
}
301301
}
302302

0 commit comments

Comments
 (0)