Modules and "Test here"

[pravic]

Sublime Text Version

Sublime Text 3 (Build 3176)

Rust Enhanced Version

2.12.0

Operating system

OS Name Microsoft Windows 7
Version 6.1 Build 7600

Expected behavior

Module tests should be run either via cargo test -- TEST_NAME or via cargo test -- --exact MOD_NAME::TEST_NAME.

Actual behavior

$cargo test -- --exact TEST_NAME which is, obviously, won't be run because --exact requires full name of a test.

Steps to reproduce

1. A new library project with lib.rs and mod_name.rs which contains a #[test] fn mod_test() test.

$ cargo test -- --list
lib_test: test
mod_name::mod_test: test

$cargo test -- --exact mod_test
running 0 tests

$cargo test -- mod_test
running 1 tests

[ehuss]

Yea, this has been on my list for a while. The problem with not using --exact is that it will match multiple tests sometimes. Trying to reverse engineer the path is quite difficult. My preferred solution is to add the ability to specify the filename/lineno to libtest, but I haven't gotten around to it and I'm not sure it would be accepted.

[pravic]

Trying to reverse engineer the path is quite difficult.

Could you tell more? You mean to get a module path from the editor? Or something else?

As for the possible duplicates.. For me, to run more tests (if one hasn't care to give them proper names) is better than to run nothing. Is it worth an option in settings?

[pravic]

And by the way, we can obtain all tests from the --list. It looks pretty easy to figure out the full test name based on the current file's name and a cursor pointed test name. Correct?

[ehuss]

Could you tell more? You mean to get a module path from the editor? Or something else?

Given the file src/foo/bar.rs, figuring out the path to the item on line 123 can't be done without parsing the entire crate (since files don't necessarily match the module hierarchy). It can maybe be done with the rust-analysis data, but that would probably be quite slow.

It looks pretty easy to figure out the full test name based on the current file's name and a cursor pointed test name.

It would need some rough heuristics since the test could be inside a mod block, inside a file called mod.rs, etc.

It would probably just be best to remove --exact until a better solution is available.

[pravic]

Indeed. I forgot about `mod` blocks. -- Yury