Fix incorrect format-arg inlining

An edge case with format arguments being wrapped in parentesis

Author: nyurik

clippy_lints/src/format_args.rs

@@ -199,7 +199,7 @@ fn check_uninlined_args(cx: &LateContext<'_>, args: &FormatArgsExpn<'_>, call_si
 fn check_one_arg(cx: &LateContext<'_>, param: &FormatParam<'_>, fixes: &mut Vec<(Span, String)>) -> bool {
     if matches!(param.kind, Implicit | Starred | Named(_) | Numbered)
         && let ExprKind::Path(QPath::Resolved(None, path)) = param.value.kind
-        && let Path { span, segments, .. } = path
+        && let Path { segments, .. } = path
         && let [segment] = segments
     {
         let replacement = match param.usage {
@@ -208,7 +208,7 @@ fn check_one_arg(cx: &LateContext<'_>, param: &FormatParam<'_>, fixes: &mut Vec<
             FormatParamUsage::Precision => format!(".{}$", segment.ident.name),
         };
         fixes.push((param.span, replacement));
-        let arg_span = expand_past_previous_comma(cx, *span);
+        let arg_span = expand_past_previous_comma(cx, param.value.span);
         fixes.push((arg_span, String::new()));
         true  // successful inlining, continue checking
     } else {

tests/ui/uninlined_format_args.fixed

@@ -1,12 +1,14 @@
 // run-rustfix
 
-#![allow(clippy::eq_op)]
-#![allow(clippy::format_in_format_args)]
-#![allow(clippy::print_literal)]
-#![allow(named_arguments_used_positionally)]
-#![allow(unused_variables, unused_imports, unused_macros)]
-#![warn(clippy::uninlined_format_args)]
 #![feature(custom_inner_attributes)]
+#![warn(clippy::uninlined_format_args)]
+#![allow(named_arguments_used_positionally, unused_imports, unused_macros, unused_variables)]
+#![allow(
+    clippy::double_parens,
+    clippy::eq_op,
+    clippy::format_in_format_args,
+    clippy::print_literal
+)]
 
 macro_rules! no_param_str {
     () => {
@@ -129,6 +131,10 @@ fn tester(fn_arg: i32) {
     println!("{}", format!("{local_i32}"));
     my_println!("{}", local_i32);
     my_println_args!("{}", local_i32);
+    println!("{local_i32}");
+    #[rustfmt::skip]
+    println!("{local_i32}");
+    println!("{local_i32:width$.prec$}");
 
     // these should NOT be modified by the lint
     println!(concat!("nope ", "{}"), local_i32);

tests/ui/uninlined_format_args.rs

@@ -1,12 +1,14 @@
 // run-rustfix
 
-#![allow(clippy::eq_op)]
-#![allow(clippy::format_in_format_args)]
-#![allow(clippy::print_literal)]
-#![allow(named_arguments_used_positionally)]
-#![allow(unused_variables, unused_imports, unused_macros)]
-#![warn(clippy::uninlined_format_args)]
 #![feature(custom_inner_attributes)]
+#![warn(clippy::uninlined_format_args)]
+#![allow(named_arguments_used_positionally, unused_imports, unused_macros, unused_variables)]
+#![allow(
+    clippy::double_parens,
+    clippy::eq_op,
+    clippy::format_in_format_args,
+    clippy::print_literal
+)]
 
 macro_rules! no_param_str {
     () => {
@@ -132,6 +134,10 @@ fn tester(fn_arg: i32) {
     println!("{}", format!("{}", local_i32));
     my_println!("{}", local_i32);
     my_println_args!("{}", local_i32);
+    println!("{}", (local_i32));
+    #[rustfmt::skip]
+    println!("{}", ((local_i32)));
+    println!("{0:1$.2$}", (local_i32), (width), (prec));
 
     // these should NOT be modified by the lint
     println!(concat!("nope ", "{}"), local_i32);