Skip to content

Commit e83dc7e

Browse files
committed
Extend spans to include !.
1 parent ddab2b8 commit e83dc7e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

clippy_lints/src/methods/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3220,7 +3220,7 @@ fn lint_filetype_is_file(cx: &LateContext<'_, '_>, expr: &hir::Expr<'_>, args: &
32203220
then {
32213221
let lint_msg = "`!FileType::is_file()` does not deny all readable file types";
32223222
let help_msg = "use `FileType::is_dir()` instead";
3223-
span_help_and_lint(cx, FILETYPE_IS_FILE, expr.span, lint_msg, help_msg);
3223+
span_help_and_lint(cx, FILETYPE_IS_FILE, parent.span, lint_msg, help_msg);
32243224
} else {
32253225
let lint_msg = "`FileType::is_file()` does not cover all readable file types";
32263226
let help_msg = "use `!FileType::is_dir()` instead";

tests/ui/filetype_is_file.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ LL | if fs::metadata("foo.txt")?.file_type().is_file() {
88
= help: use `!FileType::is_dir()` instead
99

1010
error: `!FileType::is_file()` does not deny all readable file types
11-
--> $DIR/filetype_is_file.rs:13:9
11+
--> $DIR/filetype_is_file.rs:13:8
1212
|
1313
LL | if !fs::metadata("foo.txt")?.file_type().is_file() {
14-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
14+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1515
|
1616
= help: use `FileType::is_dir()` instead
1717

0 commit comments

Comments
 (0)