Improved message

Author: teofr

clippy_lints/src/undocumented_unsafe_blocks.rs

@@ -263,7 +263,7 @@ fn check_has_safety_comment(cx: &LateContext<'_>, item: &hir::Item<'_>, (span, h
                     UNNECESSARY_SAFETY_COMMENT,
                     span,
                     format!(
-                        "{} has safety comment, but maybe a `# Safety` segment would be better",
+                        "{} has unnecessary safety comment",
                         cx.tcx.def_descr(item.owner_id.to_def_id()),
                     ),
                     |diag| {

tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.default.stderr

@@ -426,7 +426,7 @@ help: consider removing the safety comment
 LL |         // SAFETY: ...
    |         ^^^^^^^^^^^^^^
 
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.rs:781:5
    |
 LL |     unsafe fn unsafe_comment() {}
@@ -438,7 +438,7 @@ help: consider changing the `SAFETY` comment for a `# Safety` doc comment
 LL |     // SAFETY: Bla
    |     ^^^^^^^^^^^^^^
 
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.rs:787:5
    |
 LL |     unsafe fn unsafe_block_comment() {}

tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.disabled.stderr

@@ -490,7 +490,7 @@ LL |         unsafe {}
    |
    = help: consider adding a safety comment on the preceding line
 
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.rs:781:5
    |
 LL |     unsafe fn unsafe_comment() {}
@@ -502,7 +502,7 @@ help: consider changing the `SAFETY` comment for a `# Safety` doc comment
 LL |     // SAFETY: Bla
    |     ^^^^^^^^^^^^^^
 
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.rs:787:5
    |
 LL |     unsafe fn unsafe_block_comment() {}

tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks_fixable.default.stderr

@@ -1,4 +1,4 @@
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks_fixable.rs:10:5
    |
 LL |     /// SAFETY: Bla
@@ -9,7 +9,7 @@ LL |     unsafe fn unsafe_doc_comment() {}
    = note: `-D clippy::unnecessary-safety-comment` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::unnecessary_safety_comment)]`
 
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks_fixable.rs:16:5
    |
 LL |      * SAFETY: Bla

tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks_fixable.disabled.stderr

@@ -1,4 +1,4 @@
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks_fixable.rs:10:5
    |
 LL |     /// SAFETY: Bla
@@ -9,7 +9,7 @@ LL |     unsafe fn unsafe_doc_comment() {}
    = note: `-D clippy::unnecessary-safety-comment` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::unnecessary_safety_comment)]`
 
-error: function has safety comment, but maybe a `# Safety` segment would be better
+error: function has unnecessary safety comment
   --> tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks_fixable.rs:16:5
    |
 LL |      * SAFETY: Bla