Extract semantic constant

thiagoarrais · thiagoarrais · commit 7d1a9447ea15 · 2019-07-08T17:51:13.000-03:00
diff --git a/clippy_lints/src/strings.rs b/clippy_lints/src/strings.rs
@@ -138,6 +138,9 @@ fn is_add(cx: &LateContext<'_, '_>, src: &Expr, target: &Expr) -> bool {
     }
 }
 
+// Max length a b"foo" string can take
+const MAX_LENGTH_BYTE_STRING_LIT: usize = 32;
+
 declare_lint_pass!(StringLitAsBytes => [STRING_LIT_AS_BYTES]);
 
 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for StringLitAsBytes {
@@ -173,7 +176,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for StringLitAsBytes {
                             );
                         } else if callsite == expanded
                             && lit_content.as_str().chars().all(|c| c.is_ascii())
-                            && lit_content.as_str().len() <= 32
+                            && lit_content.as_str().len() <= MAX_LENGTH_BYTE_STRING_LIT
                             && !in_macro_or_desugar(args[0].span)
                         {
                             span_lint_and_sugg(

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,9 @@ fn is_add(cx: &LateContext<'_, '_>, src: &Expr, target: &Expr) -> bool {`
`138`	`138`	`}`
`139`	`139`	`}`
`140`	`140`
	`141`	`+// Max length a b"foo" string can take`
	`142`	`+const MAX_LENGTH_BYTE_STRING_LIT: usize = 32;`
	`143`	`+`
`141`	`144`	`declare_lint_pass!(StringLitAsBytes => [STRING_LIT_AS_BYTES]);`
`142`	`145`
`143`	`146`	`impl<'a, 'tcx> LateLintPass<'a, 'tcx> for StringLitAsBytes {`
`@@ -173,7 +176,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for StringLitAsBytes {`
`173`	`176`	`);`
`174`	`177`	`} else if callsite == expanded`
`175`	`178`	`&& lit_content.as_str().chars().all(\|c\| c.is_ascii())`
`176`		`- && lit_content.as_str().len() <= 32`
	`179`	`+ && lit_content.as_str().len() <= MAX_LENGTH_BYTE_STRING_LIT`
`177`	`180`	`&& !in_macro_or_desugar(args[0].span)`
`178`	`181`	`{`
`179`	`182`	`span_lint_and_sugg(`