Fix adjacent code

Author: smoelius

clippy_dev/src/new_lint.rs

@@ -95,7 +95,7 @@ fn create_lint(lint: &LintData<'_>, enable_msrv: bool) -> io::Result<()> {
     } else {
         let lint_contents = get_lint_file_contents(lint, enable_msrv);
         let lint_path = format!("clippy_lints/src/{}.rs", lint.name);
-        write_file(&lint_path, lint_contents.as_bytes())?;
+        write_file(&lint_path, &lint_contents)?;
         println!("Generated lint file: `{lint_path}`");
 
         Ok(())
@@ -433,7 +433,7 @@ fn create_lint_for_ty(lint: &LintData<'_>, enable_msrv: bool, ty: &str) -> io::R
         );
     }
 
-    write_file(lint_file_path.as_path(), lint_file_contents)?;
+    write_file(&lint_file_path, lint_file_contents)?;
     println!("Generated lint file: `clippy_lints/src/{ty}/{}.rs`", lint.name);
     println!(
         "Be sure to add a call to `{}::check` in `clippy_lints/src/{ty}/mod.rs`!",

clippy_dev/src/utils.rs

@@ -633,7 +633,7 @@ pub fn try_rename_dir(old_name: &Path, new_name: &Path) -> bool {
 
 #[track_caller]
 pub fn run_exit_on_err(path: &(impl AsRef<Path> + ?Sized), cmd: &mut Command) {
-    match expect_action(cmd.status(), ErrAction::Run, path.as_ref()).code() {
+    match expect_action(cmd.status(), ErrAction::Run, path).code() {
         Some(0) => {},
         Some(n) => process::exit(n),
         None => {
@@ -693,7 +693,7 @@ pub fn split_args_for_threads(
             let mut cmd = (self.make_cmd)();
             let mut cmd_len = 0usize;
             for arg in self.args.by_ref().take(self.batch_size) {
-                cmd.arg(arg.as_ref());
+                cmd.arg(&arg);
                 // `+ 8` to account for the `argv` pointer on unix.
                 // Windows is complicated since the arguments are first converted to UTF-16ish,
                 // but this needs to account for the space between arguments and whatever additional

clippy_lints/src/almost_complete_range.rs

@@ -60,7 +60,7 @@ impl EarlyLintPass for AlmostCompleteRange {
                         diag.span_suggestion(
                             trim_span(cx.sess().source_map(), start.between(end)),
                             "use an inclusive range",
-                            "..=".to_owned(),
+                            "..=",
                             Applicability::MaybeIncorrect,
                         );
                     }

clippy_lints/src/matches/single_match.rs

@@ -395,13 +395,9 @@ impl<'a> PatState<'a> {
             PatKind::Tuple(pats, _) => self.add_product_pat(cx, pats),
             PatKind::Slice(head, _, tail) => self.add_product_pat(cx, head.iter().chain(tail)),
 
-            PatKind::TupleStruct(ref path, pats, _) => self.add_struct_pats(
-                cx,
-                pat,
-                path,
-                if let [pat] = pats { Some(pat) } else { None },
-                pats.iter(),
-            ),
+            PatKind::TupleStruct(ref path, pats, _) => {
+                self.add_struct_pats(cx, pat, path, if let [pat] = pats { Some(pat) } else { None }, pats)
+            },
             PatKind::Struct(ref path, pats, _) => self.add_struct_pats(
                 cx,
                 pat,

clippy_lints/src/methods/open_options.rs

@@ -189,7 +189,7 @@ fn check_open_options(cx: &LateContext<'_>, settings: &[(OpenOption, Argument, S
                 diag.span_suggestion(
                     create_span.shrink_to_hi(),
                     "add",
-                    ".truncate(true)".to_string(),
+                    ".truncate(true)",
                     rustc_errors::Applicability::MaybeIncorrect,
                 )
                 .help("if you intend to overwrite an existing file entirely, call `.truncate(true)`")

clippy_lints/src/methods/vec_resize_to_zero.rs

@@ -39,7 +39,7 @@ pub(super) fn check<'tcx>(
                 db.span_suggestion(
                     method_call_span,
                     "...or you can empty the vector with",
-                    "clear()".to_string(),
+                    "clear()",
                     Applicability::MaybeIncorrect,
                 );
             },

clippy_lints/src/misc.rs

@@ -292,9 +292,9 @@ fn used_underscore_items<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
             cx,
             USED_UNDERSCORE_ITEMS,
             expr.span,
-            "used underscore-prefixed item".to_string(),
+            "used underscore-prefixed item",
             |diag| {
-                diag.span_note(definition_span, "item is defined here".to_string());
+                diag.span_note(definition_span, "item is defined here");
             },
         );
     }
@@ -337,9 +337,9 @@ fn used_underscore_binding<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
             cx,
             USED_UNDERSCORE_BINDING,
             expr.span,
-            "used underscore-prefixed binding".to_string(),
+            "used underscore-prefixed binding",
             |diag| {
-                diag.span_note(definition_span, "binding is defined here".to_string());
+                diag.span_note(definition_span, "binding is defined here");
             },
         );
     }

clippy_lints/src/misc_early/zero_prefixed_literal.rs

@@ -16,7 +16,7 @@ pub(super) fn check(cx: &EarlyContext<'_>, lit_span: Span, lit_snip: &str) {
             diag.span_suggestion(
                 lit_span,
                 "if you mean to use a decimal constant, remove the `0` to avoid confusion",
-                trimmed_lit_snip.to_string(),
+                trimmed_lit_snip,
                 Applicability::MaybeIncorrect,
             );
             // do not advise to use octal form if the literal cannot be expressed in base 8.

clippy_lints/src/needless_pass_by_ref_mut.rs

@@ -279,7 +279,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByRefMut<'tcx> {
                         |diag| {
                             diag.span_suggestion(
                                 sp,
-                                "consider changing to".to_string(),
+                                "consider changing to",
                                 format!("&{}", snippet(cx, cx.tcx.hir_span(inner_ty.ty.hir_id), "_"),),
                                 Applicability::Unspecified,
                             );

clippy_lints/src/redundant_pub_crate.rs

@@ -63,12 +63,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantPubCrate {
                 span,
                 format!("pub(crate) {descr} inside private module"),
                 |diag| {
-                    diag.span_suggestion(
-                        item.vis_span,
-                        "consider using",
-                        "pub".to_string(),
-                        Applicability::MachineApplicable,
-                    );
+                    diag.span_suggestion(item.vis_span, "consider using", "pub", Applicability::MachineApplicable);
                 },
             );
         }