Skip to content

Add the --override-abi option#2329

Merged
pvdrz merged 8 commits intorust-lang:masterfrom
ferrous-systems:override-abi
Nov 2, 2022
Merged

Add the --override-abi option#2329
pvdrz merged 8 commits intorust-lang:masterfrom
ferrous-systems:override-abi

Conversation

@pvdrz
Copy link
Copy Markdown
Contributor

@pvdrz pvdrz commented Nov 1, 2022

This option can be used from the CLI with the : syntax and it overrides the ABI of a function if it matches .

Fixes #2257 as the ".*" regex can be used to match every function.

@pvdrz
Add the --override-abi option.
89b54c0 
This option can be used from the CLI with the <abi>:<regex> syntax and
it overrides the ABI of a function if it matches <regex>.

Fixes rust-lang#2257 as the `".*"` regex can be used to match every function.
@pvdrz pvdrz requested a review from emilio November 1, 2022 20:01
emilio
emilio approved these changes Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with that simplification.

Comment thread bindgen/ir/function.rs Outdated
Comment thread bindgen/codegen/mod.rs Outdated
@pvdrz
Copy link
Copy Markdown
Contributor Author

pvdrz commented Nov 2, 2022 •
edited
Loading

@emilio before we move forward with this, we have this question in #2328 where eventually people would like to have another option with the shape <extra_arg><separator><regex>. Maybe we should agree on the separator before moving forward? I used : here but for the other use of this : won't work because <extra_arg> contains :.

Another suggested option is / but I don't know if that's clear enough

@pvdrz pvdrz merged commit 9c32b46 into rust-lang:master Nov 2, 2022
@pvdrz pvdrz deleted the override-abi branch November 2, 2022 20:30
@hcldan
Copy link
Copy Markdown
Contributor

hcldan commented Dec 1, 2022

@pvdrz The option doc was not updated with the new = char change you made.
Also I think you have the abi=regex backwards in the doc. Is it not regex=abi based on the examples in the tests?

@hcldan
Copy link
Copy Markdown
Contributor

hcldan commented Dec 1, 2022

Looks like this got caught in another PR. Nevermind.

@pvdrz
Copy link
Copy Markdown
Contributor Author

pvdrz commented Dec 5, 2022

@hcldan thanks for checking this up! I'm trying to keep those changes in a single PR to avoid this confusion in the future :)

@Ralith Ralith mentioned this pull request Jul 6, 2023
Closed
@windy1 windy1 mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilio emilio emilio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

default ABI

3 participants

@pvdrz @hcldan @emilio