rust-analyzer uses an identically named method from a wrong trait

[newpavlov]

Using rust-analyzer on this crate (note the commit hash) results in two false-positive compilation errors (i.e. compiling the same code with cargo produces no errors). One of the errors is on this line:

    #[inline]
    fn encrypt_to_vec<'msg, 'aad>(
        &self,
        nonce: &Nonce<Self>,
        pt_payload: impl Into<Payload<'msg, 'aad>>,
    ) -> Result<Vec<u8>> {
        let mut buf = Vec::new();
        self.encrypt_to_buffer(nonce, pt_payload, &mut buf)?;
        // expected 4 arguments, found 3 (E0107)         ^
        Ok(buf)
    }

Clicking on the encrypt_to_buffer method jumps to the DynAead::encrypt_to_buffer method, while Aead::encrypt_to_buffer should've been used instead.

rust-analyzer version: 0.3.2188
rustc version: 1.84.0-nightly (5ec7d6eee 2024-11-17)

[lnicola]

Probably same as #5514.

[newpavlov]

Considering that the issue is 4 years old, it does not look like it. The code was working fine until I updated rust-analyzer today. Unfortunately, I don't know the exact version which I was using before.

[newpavlov]

v0.3.2180 handles the code without issues, so it's a relatively recent regression.

UPD: I was wrong. For some reason the errors did not get triggered without saving the file.

[vorporeal]

I started noticing the same thing in my codebase upon updating our Rust toolchain to 1.83 (from 1.82). Just updated to 1.84 and the issue persists.

Very much seems like a recent regression.

EDIT with more details:

I'm seeing this issue through the rust-analyzer VSCode extension (version v0.3.2264). It started occurring upon updating my rust-toolchain.toml file to 1.83 from 1.82, and persists when I update to 1.84.

Of note: if I set "rust-analyzer.server.path": "~/.cargo/bin/rust-analyzer", in my VSCode configuration, things work properly (with the toolchain override set to 1.84).

[Expurple]

I'm hitting the same problem on some (but not all) calls to sea_orm::EntityTrait::find in my proprietary codebase. rust-analyzer confuses this method with std::Iterator::find and reports a false-positive error: expected 2 arguments, found 0 (E0107).

I use rust-analyzer in VSCode, currently at 0.3.2466. I remember seeing this for a few months at least. Only now got to google/report it.

Ping me when the original reproducer stops reproducing the issue. I'll check on my project and make a new reproducer if the issue persists.

[shssoichiro]

I have also been encountering this problem. It is reproducible in the rav1e repository, which has an implemented method clamp on the PlaneSlice struct, which rust-analyzer mistakes for core::cmp::Ord::clamp. Rustc does not make this mistake, but rust-analyzer does.