Parsing of the thread_local macro doesn't work
#15585
Comments
|
hmm odd, this works fine for me on current r-a nightly, though I am on windows with 1.74-nightly rust. I don't think anything changed in std lib there though |
|
Doesn't work for me on Linux, not sure if we support macros 2.0. |
|
Sorry I didn't mention earlier, my system is linux and for nightly - the same behavior $ rust-analyzer --version
rust-analyzer 1.74.0-nightly (62ebe3a 2023-09-08)
$ rustc -V
rustc 1.74.0-nightly (62ebe3a2b 2023-09-08)
$ lsb_release -a
Distributor ID: Ubuntu
Description: Ubuntu 22.04.3 LTS
Release: 22.04
Codename: jammy |
|
Doesn't work on macos. |
|
Expands more or less correctly now, can you confirm @sergey-tikhonenko?
|
|
I see the same behaviour for both versions:
LSP method = "rust-analyzer/expandMacro" returns the following expansion = see LSP log PS.
|
|
|
|
Thanks, as a workaround, this works for me. |
Summary
Parsing of the
thread_localmacro doesn't work for me. Also the following methods don't work for thethread_localmacro and theTLVvariable:Looks like recursive macro expansion doesn't work, see output for detail. It returns the
thread_local_innermacro instead of an expanded code.Code
Expand output
LSP log
LSP Log for hover, definition, references
But
cargo expandworks as expected:$ cargo expand Checking thread-local v0.1.0 (/home/tserge/work/sandbox/rust/learn-rust-snippets/thread-local) Finished dev [unoptimized + debuginfo] target(s) in 0.02s #![feature(prelude_import)] #[prelude_import] use std::prelude::rust_2021::*; #[macro_use] extern crate std; use std::{cell::RefCell, sync::RwLock}; static V: RwLock<i32> = RwLock::new(1); const TLV: ::std::thread::LocalKey<RefCell<i32>> = { #[inline] fn __init() -> RefCell<i32> { RefCell::new(1) } #[inline] unsafe fn __getit( init: ::std::option::Option<&mut ::std::option::Option<RefCell<i32>>>, ) -> ::std::option::Option<&'static RefCell<i32>> { #[thread_local] static __KEY: ::std::thread::local_impl::Key<RefCell<i32>> = ::std::thread::local_impl::Key::< RefCell<i32>, >::new(); #[allow(unused_unsafe)] unsafe { __KEY .get(move || { if let ::std::option::Option::Some(init) = init { if let ::std::option::Option::Some(value) = init.take() { return value; } else if true { { ::core::panicking::panic_fmt( format_args!( "internal error: entered unreachable code: {0}", format_args!("missing default value"), ), ); }; } } __init() }) } } unsafe { ::std::thread::LocalKey::new(__getit) } }; fn main() { match (&*V.read().unwrap(), &1) { (left_val, right_val) => { if !(*left_val == *right_val) { let kind = ::core::panicking::AssertKind::Eq; ::core::panicking::assert_failed( kind, &*left_val, &*right_val, ::core::option::Option::None, ); } } }; TLV.with(|tlv| match (&*tlv.borrow(), &1) { (left_val, right_val) => { if !(*left_val == *right_val) { let kind = ::core::panicking::AssertKind::Eq; ::core::panicking::assert_failed( kind, &*left_val, &*right_val, ::core::option::Option::None, ); } } }); { ::std::io::_print(format_args!("TLV: {0:?}\n", TLV)); }; }rust-analyzer version: rust-analyzer 0.3.1649-standalone
rustc version: rustc 1.72.0 (5680fa18f 2023-08-23)
relevant settings: (eg. client settings, or environment variables like
CARGO,RUSTC,RUSTUP_HOMEorCARGO_HOME)$ rustup -V
rustup 1.26.0 (5af9b94 2023-04-05)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active
rustcversion isrustc 1.72.0 (5680fa18f 2023-08-23)The text was updated successfully, but these errors were encountered: