Merge #10167

bors[bot] · lnicola · web-flow · commit 7d9eb4fd7397 · 2021-09-06T15:15:10.000Z
10167: minor: Avoid extra allocation in completion rendering r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola &lt;lnicola@dend.ro&gt;
diff --git a/crates/ide_completion/src/render.rs b/crates/ide_completion/src/render.rs
@@ -101,7 +101,7 @@ pub(crate) fn render_field(
         .lookup_by(name.as_str());
     let is_keyword = SyntaxKind::from_keyword(name.as_str()).is_some();
     if is_keyword && !matches!(name.as_str(), "self" | "crate" | "super" | "Self") {
-        item.insert_text(String::from("r#") + name.as_str());
+        item.insert_text(format!("r#{}", name));
     }
     if let Some(_ref_match) = compute_ref_match(ctx.completion, ty) {
         // FIXME

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ pub(crate) fn render_field(`
`101`	`101`	`.lookup_by(name.as_str());`
`102`	`102`	`let is_keyword = SyntaxKind::from_keyword(name.as_str()).is_some();`
`103`	`103`	`if is_keyword && !matches!(name.as_str(), "self" \| "crate" \| "super" \| "Self") {`
`104`		`- item.insert_text(String::from("r#") + name.as_str());`
	`104`	`+ item.insert_text(format!("r#{}", name));`
`105`	`105`	`}`
`106`	`106`	`if let Some(_ref_match) = compute_ref_match(ctx.completion, ty) {`
`107`	`107`	`// FIXME`