Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Configurability of rls-blacklist #1328

Closed
Xanewok opened this issue Feb 25, 2019 · 3 comments · Fixed by #1509
Closed

Configurability of rls-blacklist #1328

Xanewok opened this issue Feb 25, 2019 · 3 comments · Fixed by #1509
Labels
enhancement Indicates new feature requests package: rls-blacklist

Comments

@Xanewok
Copy link
Member

Xanewok commented Feb 25, 2019

Opened by @dweinstein (rust-dev-tools/rls-blacklist#4):

Based on reading rls-* documentation it sounded like rls blacklists are supposed to be configurable, but based on the implementation here I don't see that currently being possible. Is the goal for rls-blacklist to be configurable? via environment, config file?

@lijinpei
Copy link
Contributor

There are other issues that demands a conf file or command line arguments.
#915
#1109
#1209
#1303
#1324
#1325
Maybe those issues can be solved together?

@Xanewok Xanewok added the enhancement Indicates new feature requests label Mar 3, 2019
@tomusdrw
Copy link

I'd be happy to help out, but will need some code pointers and guidance, anyone available for mentoring?

@Xanewok
Copy link
Member Author

Xanewok commented Jul 9, 2019

@tomusdrw sorry for not responding earlier; turns out that this ended up as a yak-shave when I tried to clean up the repo a bit yesterday.
Re mentoring FWIW one can look at the changes from #1509. This spanned multiple crates so it wasn't as straightforward but I hope it makes sense. In general contributions would be more than welcome =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Indicates new feature requests package: rls-blacklist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants