Skip to content

Meta RFC: Merge rejected RFCs #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kud1ing opened this issue Apr 4, 2014 · 5 comments
Closed

Meta RFC: Merge rejected RFCs #28

kud1ing opened this issue Apr 4, 2014 · 5 comments
Labels
T-core Relevant to the core team, which will review and decide on the RFC.

Comments

@kud1ing
Copy link

kud1ing commented Apr 4, 2014

When an RFC is rejected today, the proposed details might be interesting tomorrow.
Currently for this purpose the submitter needs to keep his branch around forever.

I propose to merge interesting/controversial rejected RFC for archival purposes in a subdirectory "rejected/".
@huonw
Copy link
Member

huonw commented Apr 4, 2014

You can submit an amendment to active/0001-rfc-process.md as an RFC to adjust the process.

@asb
Copy link

asb commented Apr 4, 2014

There seems to be a real problem with preserving history here. Proposed RFCs+discussion are lost when the original submitter deletes their branch, and comments on outdated commits are believed to be lost when github GCs that commit. It's sounding like a tool to archive/export this stuff from github for posterity is needed.

@huonw
Copy link
Member

huonw commented Apr 4, 2014

(see also #14)

@bstrie
Copy link
Contributor

bstrie commented Apr 4, 2014

Agreed, without some ability to preserve historical discussions then PRs as a platform for RFCs are useless to us.

@kud1ing
Copy link
Author

kud1ing commented May 1, 2014

Rejected RFCs seem to be merged, as proposed: https://github.com/rust-lang/rfcs/tree/master/rejected
Closing.

@kud1ing kud1ing closed this as completed May 1, 2014
sfackler added a commit to sfackler/rfcs that referenced this issue Jul 1, 2014
@sfackler
RFC rust-lang#28 is complete
2e50d71
withoutboats pushed a commit to withoutboats/rfcs that referenced this issue Jan 15, 2017
@alexcrichton
Merge pull request rust-lang#28 from lexxvir/patch-1
33c80a8 
Fix typo (repeated text).
@Centril Centril added the T-core Relevant to the core team, which will review and decide on the RFC. label Feb 23, 2018
wycats pushed a commit to wycats/rust-rfcs that referenced this issue Mar 5, 2019
@rwjblue
Merge pull request rust-lang#28 from ember-cli/app-import-output-file
986c703 
Add support for app.import(…, {outputFile: …})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-core Relevant to the core team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asb @kud1ing @Centril @bstrie @huonw