Skip to content

Commit a81b5a6

Browse files
committed
Mention that target_feature is already allowed on inherent methods and this RFC does not change that
1 parent 6e5ce9d commit a81b5a6

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

text/0000-target-feature-1.1.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,9 @@ This change already solves all three issues mentioned in the motivation:
124124
calls-sites across which they cannot be inlined while making call-sites across
125125
which they can be inlined more ergonomic to write.
126126

127+
The `#[target_feature]` attribute continues to be allowed on inherent methods -
128+
this RFC does not change that.
129+
127130
The `#[target_feature]` attribute continues to not be allowed on safe trait
128131
method implementations:
129132

@@ -182,12 +185,7 @@ unnecessarily complicate future language features like an effect system.
182185

183186
Since `#[target_feature]` are effects or restrictions (depending on whether we
184187
`enable` or `disable` them), the alternative would be to integrate them with an
185-
effect system. Since `#[target_feature]` is already on its path to stabilization
186-
and its required to make SIMD in Rust minimally useful, not stabilizing
187-
`#[target_feature]` at this point is not an option unless we are willing to
188-
delay SIMD until an effect system is stabilized. Until then, `#[target_feature]`
189-
and this RFC solve real problems and provide another use-case that such an
190-
effect system will need to enable to be useful for Rust programmers.
188+
effect system.
191189

192190
# Prior art
193191
[prior-art]: #prior-art

0 commit comments

Comments
 (0)