Skip to content

Commit 91fc5e6

Browse files
joshtriplettJoshua Nelson
authored and
Joshua Nelson
committed
Qualify mentions of CI to include all components Rust's CI considers mandatory
1 parent 7ac0c04 commit 91fc5e6

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

text/0000-target-tier-policy.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,8 @@ by an infrastructure team member reporting the outcome of a team discussion.
349349
convention for C code, the Rust target must support that C calling convention
350350
for the platform via `extern "C"`. The C calling convention does not need to
351351
be the default Rust calling convention for the target, however.
352-
- The target must build reliably in CI.
352+
- The target must build reliably in CI, for all components that Rust's CI
353+
considers mandatory.
353354
- The approving teams may additionally require that a subset of tests pass in
354355
CI, such as enough to build a functional "hello world" program, `./x.py test
355356
--no-run`, or equivalent "smoke tests". In particular, this requirement may
@@ -450,8 +451,8 @@ member reporting the outcome of a team discussion.
450451
others.
451452
- There must be a reasonable expectation that the host tools will be used, for
452453
purposes other than to prove that they can be used.
453-
- The host tools must build and run reliably in CI, though they may or may not
454-
pass tests.
454+
- The host tools must build and run reliably in CI (for all components that
455+
Rust's CI considers mandatory), though they may or may not pass tests.
455456
- Building host tools for the target must not take substantially longer than
456457
building host tools for other targets, and should not substantially raise the
457458
maintenance burden of the CI infrastructure.
@@ -534,7 +535,8 @@ including the infrastructure team in the RFC proposing the target.
534535
target may be demoted or removed if it becomes obsolete or no longer meets
535536
this requirement.
536537
- The target maintainer team must include at least 3 developers.
537-
- The target must build and pass tests reliably in CI.
538+
- The target must build and pass tests reliably in CI, for all components that
539+
Rust's CI considers mandatory.
538540
- The target must not disable an excessive number of tests or pieces of tests
539541
in the testsuite in order to do so. This is a subjective requirement.
540542
- If the target does not have host tools support, or if the target has low
@@ -652,7 +654,8 @@ team in the RFC proposing the target.
652654
sufficient interest for cross-compilation, but not have sufficient interest
653655
for native compilation. The host tools may be dropped if they no longer meet
654656
this requirement, even if the target otherwise qualifies as tier 1.
655-
- The host tools must build, run, and pass tests reliably in CI.
657+
- The host tools must build, run, and pass tests reliably in CI, for all
658+
components that Rust's CI considers mandatory.
656659
- The target must not disable an excessive number of tests or pieces of tests
657660
in the testsuite in order to do so. This is a subjective requirement.
658661
- Building the host tools and running the testsuite for the host tools must not

0 commit comments

Comments
 (0)