Skip to content

Controllable auto-close/postpone behavior #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Centril opened this issue Apr 30, 2018 · 2 comments
Closed

Controllable auto-close/postpone behavior #201

Centril opened this issue Apr 30, 2018 · 2 comments

Comments

@Centril
Copy link
Contributor

Centril commented Apr 30, 2018 •
edited
Loading

See discussion on #197 and #92.

Possible control mechanism in the teams.toml file (renamed to rfcbot.toml):

[fcp_behaviour."rust-lang/rfcs"]
close = true
postpone = true

[teams]

# other stuff....
@anp
Copy link
Member

anp commented Apr 30, 2018

This style looks good to me!

@anp
Copy link
Member

anp commented Apr 30, 2018

To answer your question from the PR:

One thing I'm a bit unsure about as to making this work for all repos is whether there is one instance of the rfcbot program running for rust-lang/rust and rust-lang/rfcs or if there are separate instances for each.

There's only one instance of rfcbot running for all repos it watches at the moment, so I think we'll need the behavior to be configurable.

Centril added a commit that referenced this issue May 15, 2018
@Centril
Merge pull request #204 from Centril/various-improvements
c466689 
Fix #201 (Controllable auto-close/postpone behavior)
Centril added a commit to Centril/rfcbot-rs that referenced this issue Jun 20, 2018
@Centril
make the ffcp-auto-close/postpone behavior configurable. fixes rust-l…
9bd4bf0 
…ang#201
anoadragon453 pushed a commit to matrix-org/mscbot that referenced this issue Jul 6, 2018
@Centril
make the ffcp-auto-close/postpone behavior configurable. fixes rust-l…
c498c91 
…ang#201

Former-commit-id: 7cc9937
anoadragon453 pushed a commit to matrix-org/mscbot that referenced this issue Jul 6, 2018
@Centril
Merge pull request rust-lang#204 from Centril/various-improvements
79d53aa 
Fix rust-lang#201 (Controllable auto-close/postpone behavior)

Former-commit-id: c466689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Centril @anp