Determine if issue is PR to avoid refresh pages

tesuji · tesuji · commit bf687d51b96d · 2019-04-25T13:37:20.000+07:00
diff --git a/src/github/nag.rs b/src/github/nag.rs
@@ -1219,11 +1219,12 @@ impl<'a> RfcBotComment<'a> {
     }
 
     fn add_comment_url(issue: &Issue, msg: &mut String, comment_id: i32) {
-        let to_add = format!("https://github.com/{}/issues/{}#issuecomment-{}",
+        let url = format!("https://github.com/{}/{}/{}#issuecomment-{}",
                              issue.repository,
                              issue.number,
+                             if issue.is_pull_request { "pull" } else { "issues" },
                              comment_id);
-        msg.push_str(&to_add);
+        msg.push_str(&url);
     }
 
     fn maybe_add_pfcp_label(&self) {

Original file line number	Diff line number	Diff line change
`@@ -1219,11 +1219,12 @@ impl<'a> RfcBotComment<'a> {`
`1219`	`1219`	`}`
`1220`	`1220`
`1221`	`1221`	`fn add_comment_url(issue: &Issue, msg: &mut String, comment_id: i32) {`
`1222`		`- let to_add = format!("https://github.com/{}/issues/{}#issuecomment-{}",`
	`1222`	`+ let url = format!("https://github.com/{}/{}/{}#issuecomment-{}",`
`1223`	`1223`	`issue.repository,`
`1224`	`1224`	`issue.number,`
	`1225`	`+ if issue.is_pull_request { "pull" } else { "issues" },`
`1225`	`1226`	`comment_id);`
`1226`		`- msg.push_str(&to_add);`
	`1227`	`+ msg.push_str(&url);`
`1227`	`1228`	`}`
`1228`	`1229`
`1229`	`1230`	`fn maybe_add_pfcp_label(&self) {`