add tests for local crate detection

Author: narpfel

test-cargo-miri/Cargo.lock

@@ -17,6 +17,7 @@ issue_1567 = { path = "issue-1567" }
 issue_1691 = { path = "issue-1691" }
 issue_1705 = { path = "issue-1705" }
 issue_rust_86261 = { path = "issue-rust-86261" }
+executable = { path = "local-crate/executable" }
 
 [dev-dependencies]
 byteorder_2 = { package = "byteorder", version = "0.5" } # to test dev-dependencies behave as expected, with renaming

test-cargo-miri/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+name = "executable"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]
+library-with-dashes = { path = "../library-with-dashes" }

test-cargo-miri/local-crate/executable/Cargo.toml

@@ -0,0 +1 @@
+

test-cargo-miri/local-crate/executable/src/lib.rs

@@ -0,0 +1,4 @@
+fn main() {
+    eprintln!("{}", env!("MIRI_LOCAL_CRATES"));
+    library_with_dashes::entry_point();
+}

test-cargo-miri/local-crate/executable/src/main.rs

@@ -0,0 +1,4 @@
+[package]
+name = "library-with-dashes"
+version = "0.1.0"
+edition = "2021"

test-cargo-miri/local-crate/library-with-dashes/Cargo.toml

@@ -0,0 +1,7 @@
+pub fn entry_point() {
+    function()
+}
+
+fn function() {
+    unsafe { std::hint::unreachable_unchecked() }
+}

test-cargo-miri/local-crate/library-with-dashes/src/lib.rs

@@ -50,7 +50,7 @@ def check_output(actual, path, name):
     print(f"--- END diff {name} ---")
     return False
 
-def test(name, cmd, stdout_ref, stderr_ref, stdin=b'', env=None):
+def test(name, cmd, stdout_ref, stderr_ref, stdin=b'', env=None, expected_exit_code=0):
     if env is None:
         env = {}
     print("Testing {}...".format(name))
@@ -71,10 +71,10 @@ def test(name, cmd, stdout_ref, stderr_ref, stdin=b'', env=None):
     stdout_matches = check_output(stdout, stdout_ref, "stdout")
     stderr_matches = check_output(stderr, stderr_ref, "stderr")
 
-    if p.returncode == 0 and stdout_matches and stderr_matches:
+    if p.returncode == expected_exit_code and stdout_matches and stderr_matches:
         # All good!
         return
-    fail("exit code was {}".format(p.returncode))
+    fail(f"exit code was {p.returncode} but {expected_exit_code} was expected")
 
 def test_no_rebuild(name, cmd, env=None):
     if env is None:
@@ -131,6 +131,12 @@ def test_cargo_miri_run():
         cargo_miri("run") + ["--target-dir=custom-run", "--", "--target-dir=target/custom-run"],
         "run.args.stdout.ref", "run.custom-target-dir.stderr.ref",
     )
+    test("`cargo miri run -p executable` (local crate)",
+         cargo_miri("run") + ["--package=executable"],
+         "run.local_crate.stdout.ref", "run.local_crate.stderr.ref",
+         env={"RUSTFLAGS": f"--remap-path-prefix={os.getcwd()}=/build"},
+         expected_exit_code=1,
+    )
 
 def test_cargo_miri_test():
     # rustdoc is not run on foreign targets

test-cargo-miri/run-test.py

@@ -0,0 +1,26 @@
+subcrate,issue_1567,exported_symbol_dep,cargo_miri_test,cdylib,executable,library_with_dashes,exported_symbol,issue_1691,issue_1705,issue_rust_86261,proc_macro_crate
+error: Undefined Behavior: entering unreachable code
+ --> /build/local-crate/library-with-dashes/src/lib.rs:6:14
+  |
+6 |     unsafe { std::hint::unreachable_unchecked() }
+  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ entering unreachable code
+  |
+  = help: this indicates a bug in the program: it performed an invalid operation, and caused Undefined Behavior
+  = help: see https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html for further information
+  = note: BACKTRACE:
+  = note: inside `library_with_dashes::function` at /build/local-crate/library-with-dashes/src/lib.rs:6:14: 6:48
+note: inside `library_with_dashes::entry_point`
+ --> /build/local-crate/library-with-dashes/src/lib.rs:2:5
+  |
+2 |     function()
+  |     ^^^^^^^^^^
+note: inside `main`
+ --> local-crate/executable/src/main.rs:3:5
+  |
+3 |     library_with_dashes::entry_point();
+  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace
+
+error: aborting due to 1 previous error
+