Disable #[should_panic] test on Windows

Aaron1011 · Aaron1011 · commit 6fe89e45f44d · 2019-11-19T15:59:42.000-05:00
We should re-enable this once #1059 is fixed
diff --git a/test-cargo-miri/tests/test.rs b/test-cargo-miri/tests/test.rs
@@ -42,8 +42,13 @@ fn num_cpus() {
     assert_eq!(num_cpus::get(), 1);
 }
 
+
+// FIXME: Remove this `cfg` once we fix https://github.com/rust-lang/miri/issues/1059
+// We cfg-gate the `should_panic` attribute and the `panic!` itself, so that the test
+// stdout does not depend on the platform
 #[test]
-#[should_panic]
+#[cfg_attr(not(windows), should_panic)]
 fn do_panic() { // In large, friendly letters :)
+    #[cfg(not(windows))]
     panic!("Explicit panic from test!");
 }

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,13 @@ fn num_cpus() {`
`42`	`42`	`assert_eq!(num_cpus::get(), 1);`
`43`	`43`	`}`
`44`	`44`
	`45`	`+`
	`46`	+// FIXME: Remove this `cfg` once we fix https://github.com/rust-lang/miri/issues/1059
	`47`	+// We cfg-gate the `should_panic` attribute and the `panic!` itself, so that the test
	`48`	`+// stdout does not depend on the platform`
`45`	`49`	`#[test]`
`46`		`-#[should_panic]`
	`50`	`+#[cfg_attr(not(windows), should_panic)]`
`47`	`51`	`fn do_panic() { // In large, friendly letters :)`
	`52`	`+ #[cfg(not(windows))]`
`48`	`53`	`panic!("Explicit panic from test!");`
`49`	`54`	`}`