-
Notifications
You must be signed in to change notification settings - Fork 63
bors should not try to merge a PR if the CI has failed #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Why would this ever be the case? I'm quite confused -- is there some context here? Bors does check the CI status (otherwise, you know, there'd be no point...?) |
Sorry, I thought someone indicated otherwise, and I must have misunderstood. |
Discussed briefly on Discord. Turns out @varkor presumably meant that if the PR CI fails, we should not then go and try to test on auto branch CI, since that's probably a waste of time. |
Yeah, it would be great if bors either waited until PR CI passed before adding the PR to the queue, or else de-queued PRs (auto- |
Maybe easier to implement - if bors could show on the queue that PR CI failed, it would at least let people know it wouldn't be included in rollups: rust-lang/rust#84716 (comment) |
Or better: if CI fails, then it automatically gets Oh that was said |
Another approach to this is |
In the rare occasions we might want to merge even if CI has failed, we should explicitly command @bors to ignore the CI failure.
The text was updated successfully, but these errors were encountered: