Test that @bors retry resets the state

Test that issuing a `@bors retry` command moves the state from 'pending'
to '' for pending pull requests. This is frequently used as a way to
yield the current build to a different pull request.

Author: bryanburgers

homu/pull_req_state.py

@@ -675,18 +675,21 @@ def process_issue_comment(self, event, command):
 #                        delegate=state.delegate
 #                    ))
 #
-#            elif command.action == 'retry' and realtime:
-#                _assert_try_auth_verified()
-#
-#                state.set_status('')
-#                if realtime:
-#                    if state.try_:
-#                        event = LabelEvent.TRY
-#                    else:
-#                        event = LabelEvent.APPROVED
-#                    state.record_retry_log(command_src, body, global_cfg)
-#                    state.change_labels(event)
-#
+            elif command.action == 'retry':
+                _assert_try_auth_verified()
+
+                self.status = ''
+                if self.try_:
+                    event = LabelEvent.TRY
+                    self.try_state = BuildState.NONE
+                else:
+                    event = LabelEvent.APPROVED
+                    self.build_state = BuildState.NONE
+                # TODO: re-enable the retry log!
+                #self.record_retry_log(command_src, body, global_cfg)
+                result.label_events.append(event)
+                result.changed = True
+
 #            elif command.action in ['try', 'untry'] and realtime:
 #                _assert_try_auth_verified()
 #

homu/tests/test_process_event.py

@@ -540,6 +540,52 @@ def test_build_failed(_):
     assert state.try_state == BuildState.NONE
 
 
+@unittest.mock.patch('homu.pull_req_state.assert_authorized',
+                     side_effect=return_true)
+def test_build_retry_cancels(_):
+    """
+    Test that a pull request that has started a build and then gets a 'retry'
+    command cancels the build.
+    """
+
+    state = new_state()
+    result = state.process_event(create_event({
+        'eventType': 'IssueComment',
+        'author': {
+            'login': 'bors',
+        },
+        'body': '''
+            :hourglass: Building commit 065151f8b2c31d9e4ddd34aaf8d3263a997f5cfe with merge 330c85d9270b32d7703ebefc337eb37ae959f741...
+            <!-- homu: {"type":"BuildStarted","head_sha":"065151f8b2c31d9e4ddd34aaf8d3263a997f5cfe","merge_sha":"330c85d9270b32d7703ebefc337eb37ae959f741"} -->
+        ''', # noqa
+        'publishedAt': '1985-04-21T00:00:00Z',
+    }))
+
+    assert result.changed is True
+    assert state.try_ is False
+    assert state.get_status() == 'pending'
+    assert state.build_state == BuildState.PENDING
+    assert state.try_state == BuildState.NONE
+
+    result = state.process_event(create_event({
+        'eventType': 'IssueComment',
+        'author': {
+            'login': 'ferris',
+        },
+        'body': '''
+            @bors retry
+        ''',
+        'publishedAt': '1985-04-21T00:01:00Z',
+    }))
+
+    assert result.changed is True
+    assert state.try_ is False
+    assert state.get_status() == ''
+    assert state.build_state == BuildState.NONE
+    assert state.try_state == BuildState.NONE
+    # TODO: does issuing this retry emit label events?
+
+
 #def test_tried_and_approved():
 #    """
 #    Test that a pull request that has been approved AND tried shows up as