Skip to content

try_skip_while and try_take_while have inaccurate doc comments (errors are passed through) #2476

Open
@ttttcrngyblflpp

Description

@ttttcrngyblflpp

The documentation of try_take_while states:

This function is similar to StreamExt::take_while but exits early if an error occurs.

The actual behavior is that errors are passed through. It seems like the wording should be changed to match, e.g. try_filter. try_skip_while has the same problem.

Alternatively, perhaps all TryStreamExt combinators which return a TryStream should actually not yield more than one error (this is possible, e.g. if selecting between two TryStreams).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions