Skip to content

adding loop_fn_back in to the future-rs #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
warlord500 opened this issue May 14, 2021 · 4 comments
Closed

adding loop_fn_back in to the future-rs #2444

warlord500 opened this issue May 14, 2021 · 4 comments
Labels
A-future Area: futures::future C-feature-request

Comments

@warlord500
Copy link

I have created a small library that isn't entirely completed but almost there to add loop fn back in,
I wasn't entirely sure how I would alter the mod files to add it in but i think there

the library is at
https://github.com/warlord500/loop_fn_future

@ibraheemdev
Copy link
Member

Quickly reviewing the implementation, you could use futures_core::ready instead of the macro yourself and pin-project-lite instead of get_unchecked_mut.

@taiki-e
Copy link
Member

taiki-e commented May 15, 2021

What is the use case for this?

Historically, this function has been removed in favor of loop + async/await. Looking at the previous discussion it could be useful in migrating from 0.1, but it's really temporary and I don't want to enable it by default.

In any case, I would like to know about specific use cases that require this.

@taiki-e taiki-e added A-future Area: futures::future C-feature-request S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author labels May 15, 2021
@warlord500
Copy link
Author

there nothing that requires this usage, my only thought is that it could be useful if you didn't want to write a future without using async and await for example purposes!

I certainly have no problem with it being under a feature flag for migration

@taiki-e taiki-e removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author label May 19, 2021
@taiki-e
Copy link
Member

taiki-e commented May 27, 2021

I would prefer not to add this unless there is a specific use case that requires this.

@taiki-e taiki-e closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-future Area: futures::future C-feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants