Skip to content

Commit 79ae892

Browse files
committed
Fix remaining compilation errors
1 parent c131541 commit 79ae892

File tree

16 files changed

+47
-57
lines changed

16 files changed

+47
-57
lines changed

futures-core/src/task/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,3 @@ pub mod __internal;
66
pub use self::spawn::{Spawn, LocalSpawn, SpawnError};
77

88
pub use core::task::{Poll, Waker, RawWaker, RawWakerVTable};
9-
pub use self::Waker as LocalWaker;

futures-executor/src/local_pool.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ fn run_executor<T, F: FnMut(&Waker) -> Poll<T>>(mut f: F) -> T {
6767
another executor");
6868

6969
CURRENT_THREAD_NOTIFY.with(|thread_notify| {
70-
let waker: WakerRef = unsafe { waker_ref(thread_notify) };
70+
let waker: WakerRef = waker_ref(thread_notify);
7171
loop {
7272
if let Poll::Ready(t) = f(&waker) {
7373
return t;

futures-executor/src/thread_pool.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
use crate::enter;
22
use crate::unpark_mutex::UnparkMutex;
33
use futures_core::future::{Future, FutureObj};
4-
use futures_core::task::{Poll, ArcWake, Spawn, SpawnError};
4+
use futures_core::task::{Poll, Spawn, SpawnError};
55
use futures_util::future::FutureExt;
6-
use futures_util::task::waker_ref;
6+
use futures_util::task::{ArcWake, waker_ref};
77
use num_cpus;
88
use std::io;
99
use std::prelude::v1::*;

futures-test/src/task/panic_waker.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ unsafe fn wake_panic(_data: *const()) {
1313
panic!("should not be woken");
1414
}
1515

16-
unsafe fn noop_into_waker(_data: *const()) -> Option<RawWaker> {
17-
Some(raw_panic_waker())
18-
}
19-
2016
const PANIC_WAKER_VTABLE: RawWakerVTable = RawWakerVTable {
2117
clone: noop_clone,
2218
drop_fn: noop,

futures-test/src/task/wake_counter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use futures_core::task::{local_waker_from_nonlocal, Waker, Wake};
1+
use futures_core::task::{Waker};
22
use std::sync::Arc;
33
use std::sync::atomic::{AtomicUsize, Ordering};
44
use futures_util::task::ArcWake;

futures-util/src/future/catch_unwind.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ impl<Fut> Future for CatchUnwind<Fut>
2929
type Output = Result<Fut::Output, Box<dyn Any + Send>>;
3030

3131
fn poll(self: Pin<&mut Self>, waker: &Waker) -> Poll<Self::Output> {
32-
match catch_unwind(AssertUnwindSafe(|| self.future().poll(lw))) {
32+
match catch_unwind(AssertUnwindSafe(|| self.future().poll(waker))) {
3333
Ok(res) => res.map(Ok),
3434
Err(e) => Poll::Ready(Err(e))
3535
}

futures-util/src/future/join_all.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ where
135135

136136
for mut elem in iter_pin_mut(self.elems.as_mut()) {
137137
if let Some(pending) = elem.as_mut().pending_pin_mut() {
138-
if let Poll::Ready(output) = pending.poll(lw) {
138+
if let Poll::Ready(output) = pending.poll(waker) {
139139
elem.set(ElemState::Done(Some(output)));
140140
} else {
141141
all_done = false;

futures-util/src/future/shared.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
use crate::task::local_waker_ref_from_nonlocal;
1+
use crate::task::{ArcWake, waker_ref};
22
use futures_core::future::{FusedFuture, Future};
3-
use futures_core::task::{Waker, Poll, ArcWake};
3+
use futures_core::task::{Waker, Poll};
44
use slab::Slab;
55
use std::cell::UnsafeCell;
66
use std::fmt;
@@ -126,7 +126,7 @@ where
126126
};
127127

128128
if self.waker_key == NULL_WAKER_KEY {
129-
self.waker_key = wakers.insert(Some(waker.clone().into_waker()));
129+
self.waker_key = wakers.insert(Some(waker.clone()));
130130
} else {
131131
let waker_slot = &mut wakers[self.waker_key];
132132
let needs_replacement = if let Some(_old_waker) = waker_slot {
@@ -139,7 +139,7 @@ where
139139
true
140140
};
141141
if needs_replacement {
142-
*waker_slot = Some(waker.clone().into_waker());
142+
*waker_slot = Some(waker.clone());
143143
}
144144
}
145145
debug_assert!(self.waker_key != NULL_WAKER_KEY);
@@ -216,7 +216,7 @@ where
216216
_ => unreachable!(),
217217
}
218218

219-
let waker = local_waker_ref_from_nonlocal(&inner.notifier);
219+
let waker = waker_ref(&inner.notifier);
220220
let waker = &waker;
221221

222222
struct Reset<'a>(&'a AtomicUsize);

futures-util/src/lock/mutex.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ impl Waiter {
4040
fn register(&mut self, waker: &Waker) {
4141
match self {
4242
Waiter::Waiting(waker) if waker.will_wake(waker) => {},
43-
_ => *self = Waiter::Waiting(waker.clone().into_waker()),
43+
_ => *self = Waiter::Waiting(waker.clone()),
4444
}
4545
}
4646

futures-util/src/stream/futures_unordered/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
//! An unbounded set of futures.
22
3-
use crate::task::AtomicWaker;
3+
use crate::task::{AtomicWaker};
44
use futures_core::future::{Future, FutureObj, LocalFutureObj};
55
use futures_core::stream::{FusedStream, Stream};
66
use futures_core::task::{Waker, Poll, Spawn, LocalSpawn, SpawnError};
@@ -402,7 +402,7 @@ impl<Fut: Future> Stream for FuturesUnordered<Fut> {
402402
// the internal allocation, appropriately accessing fields and
403403
// deallocating the task if need be.
404404
let res = {
405-
let waker = Task::local_waker(bomb.task.as_ref().unwrap());
405+
let waker = Task::waker_ref(bomb.task.as_ref().unwrap());
406406

407407
// Safety: We won't move the future ever again
408408
let future = unsafe { Pin::new_unchecked(future) };

0 commit comments

Comments
 (0)