Skip to content

Set environment variable DOCS_RS when building crates #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jyn514 merged 3 commits into from
Jun 24, 2020
Merged

Set environment variable DOCS_RS when building crates #852

jyn514 merged 3 commits into from
Jun 24, 2020

Conversation

@ldm0
Copy link
Contributor

@ldm0 ldm0 commented Jun 24, 2020

cc #147 (comment).

Fixes #147 .

@ldm0 ldm0 mentioned this pull request Jun 24, 2020
Closed
jyn514
jyn514 approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :) I'm going to run a build locally to make sure the env variable shows up (unfortunately we don't have automated build tests: #822). Thanks for the PR!

@jyn514 jyn514 changed the title Set environment variable DOCS_RS when buliding crates Set environment variable DOCS_RS when building crates Jun 24, 2020
@jyn514
Copy link
Member

jyn514 commented Jun 24, 2020

Yes, this looks fine locally (except for me missing some styles which is a separate bug):

image
image
image

jyn514
jyn514 reviewed Jun 24, 2020
View reviewed changes
jyn514
jyn514 reviewed Jun 24, 2020
View reviewed changes
@jyn514
Copy link
Member

jyn514 commented Jun 24, 2020

👌

image

@jyn514 jyn514 merged commit 116821e into rust-lang:master Jun 24, 2020
@jyn514
Copy link
Member

jyn514 commented Jun 24, 2020

Just deployed :)

@ldm0 ldm0 deleted the envvar branch June 24, 2020 14:10
@paolobarbolini paolobarbolini mentioned this pull request Aug 3, 2020
Merged
@ilammy ilammy mentioned this pull request Aug 6, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jyn514 jyn514 jyn514 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detecting docs.rs from build.rs?

2 participants

@ldm0 @jyn514