-
Notifications
You must be signed in to change notification settings - Fork 221
Open
Labels
A-backendArea: Webserver backendArea: Webserver backendC-bugCategory: This is a bugCategory: This is a bug
Description
coming from #2040 and the comments by @Nemo157
The question I have is how did an invalid mimetype get into S3, and I probably found the answer with a little more looking, it's an old crate built in 2017 back when https://docs.rs/magic was used for mimetype detection, I'm not surprised it may have put some invalid data into the database back then.
and
(This does make me question our current default of
text/plainwhen mime detection fails while adding a file though)
Lines 549 to 551 in c927eac
let mime = mime_guess::from_path(file_path.as_ref()) .first_raw() .unwrap_or("text/plain");
We might have:
- wrong mime-types / invalid data for old crates, when
magicwas used. - a
text/plaindefault set whenmime_guessdoesn't give us anything, whereapplication/octet-streammight be the better default? ( to be discussed)
Metadata
Metadata
Assignees
Labels
A-backendArea: Webserver backendArea: Webserver backendC-bugCategory: This is a bugCategory: This is a bug