Merge #1440

1440: Upgrade clippy on CI r=carols10cents

Author: bors-voyager[bot]

.travis.yml

@@ -49,9 +49,9 @@ matrix:
   allow_failures:
     - rust: nightly
   include:
-    - rust: nightly-2018-03-31
+    - rust: nightly-2018-06-26
       script:
-        - cargo install --force clippy --vers 0.0.191
+        - cargo install --force clippy --vers 0.0.210
         - cargo clippy
     - rust: stable
       script:

src/bin/render-readmes.rs

@@ -61,7 +61,7 @@ fn main() {
     let args: Args = Docopt::new(USAGE)
         .and_then(|d| d.deserialize())
         .unwrap_or_else(|e| e.exit());
-    let config: Config = Default::default();
+    let config = Config::default();
     let conn = cargo_registry::db::connect_now().unwrap();
 
     let start_time = Utc::now();
@@ -133,10 +133,12 @@ fn main() {
         let mut tasks = Vec::with_capacity(page_size as usize);
         for (version, krate_name) in versions {
             let config = config.clone();
-            version.record_readme_rendering(&conn).expect(&format!(
-                "[{}-{}] Couldn't record rendering time",
-                krate_name, version.num
-            ));
+            version.record_readme_rendering(&conn).unwrap_or_else(|_| {
+                panic!(
+                    "[{}-{}] Couldn't record rendering time",
+                    krate_name, version.num
+                )
+            });
             let handle = thread::spawn(move || {
                 println!("[{}-{}] Rendering README...", krate_name, version.num);
                 let readme = get_readme(&config, &version, &krate_name);
@@ -155,10 +157,12 @@ fn main() {
                         "text/html",
                         readme_len as u64,
                     )
-                    .expect(&format!(
-                        "[{}-{}] Couldn't upload file to S3",
-                        krate_name, version.num
-                    ));
+                    .unwrap_or_else(|_| {
+                        panic!(
+                            "[{}-{}] Couldn't upload file to S3",
+                            krate_name, version.num
+                        )
+                    });
             });
             tasks.push(handle);
         }
@@ -181,10 +185,8 @@ fn get_readme(config: &Config, version: &Version, krate_name: &str) -> Option<St
         None => return None,
     };
     let date = Utc::now().to_rfc2822();
-    let url = Url::parse(&location).expect(&format!(
-        "[{}-{}] Couldn't parse crate URL",
-        krate_name, version.num
-    ));
+    let url = Url::parse(&location)
+        .unwrap_or_else(|_| panic!("[{}-{}] Couldn't parse crate URL", krate_name, version.num));
 
     let mut headers = List::new();
     headers
@@ -222,17 +224,21 @@ fn get_readme(config: &Config, version: &Version, krate_name: &str) -> Option<St
     let reader = Cursor::new(response);
     let reader = GzDecoder::new(reader);
     let mut archive = Archive::new(reader);
-    let mut entries = archive.entries().expect(&format!(
-        "[{}-{}] Invalid tar archive entries",
-        krate_name, version.num
-    ));
+    let mut entries = archive.entries().unwrap_or_else(|_| {
+        panic!(
+            "[{}-{}] Invalid tar archive entries",
+            krate_name, version.num
+        )
+    });
     let manifest: Manifest = {
         let path = format!("{}-{}/Cargo.toml", krate_name, version.num);
         let contents = find_file_by_path(&mut entries, Path::new(&path), version, krate_name);
-        toml::from_str(&contents).expect(&format!(
-            "[{}-{}] Syntax error in manifest file",
-            krate_name, version.num
-        ))
+        toml::from_str(&contents).unwrap_or_else(|_| {
+            panic!(
+                "[{}-{}] Syntax error in manifest file",
+                krate_name, version.num
+            )
+        })
     };
 
     let rendered = {
@@ -249,10 +255,7 @@ fn get_readme(config: &Config, version: &Version, krate_name: &str) -> Option<St
                 .as_ref()
                 .map_or("README.md", |e| &**e),
             manifest.package.repository.as_ref().map(|e| &**e),
-        ).expect(&format!(
-            "[{}-{}] Couldn't render README",
-            krate_name, version.num
-        ))
+        ).unwrap_or_else(|_| panic!("[{}-{}] Couldn't render README", krate_name, version.num))
     };
     return Some(rendered);
 
@@ -287,22 +290,28 @@ fn find_file_by_path<R: Read>(
                 filepath == path
             }
         })
-        .expect(&format!(
-            "[{}-{}] couldn't open file: {}",
-            krate_name,
-            version.num,
-            path.display()
-        ))
-        .expect(&format!(
-            "[{}-{}] file is not present: {}",
-            krate_name,
-            version.num,
-            path.display()
-        ));
+        .unwrap_or_else(|| {
+            panic!(
+                "[{}-{}] couldn't open file: {}",
+                krate_name,
+                version.num,
+                path.display()
+            )
+        })
+        .unwrap_or_else(|_| {
+            panic!(
+                "[{}-{}] file is not present: {}",
+                krate_name,
+                version.num,
+                path.display()
+            )
+        });
     let mut contents = String::new();
-    file.read_to_string(&mut contents).expect(&format!(
-        "[{}-{}] Couldn't read file contents",
-        krate_name, version.num
-    ));
+    file.read_to_string(&mut contents).unwrap_or_else(|_| {
+        panic!(
+            "[{}-{}] Couldn't read file contents",
+            krate_name, version.num
+        )
+    });
     contents
 }

src/bin/server.rs

@@ -15,7 +15,7 @@ use std::sync::Arc;
 fn main() {
     // Initialize logging
     env_logger::init().unwrap();
-    let config: cargo_registry::Config = Default::default();
+    let config = cargo_registry::Config::default();
 
     // If there isn't a git checkout containing the crate index repo at the path specified
     // by `GIT_REPO_CHECKOUT`, delete that directory and clone the repo specified by `GIT_REPO_URL`

src/controllers/token.rs

@@ -58,7 +58,7 @@ pub fn new(req: &mut Request) -> CargoResult<Response> {
         .map_err(|e| bad_request(&format!("invalid new token request: {:?}", e)))?;
 
     let name = &new.api_token.name;
-    if name.len() < 1 {
+    if name.is_empty() {
         return Err(bad_request("name must have a value"));
     }
 

src/models/team.rs

@@ -116,14 +116,14 @@ impl Team {
         // check that `team` is the `slug` in results, and grab its data
 
         // "sanitization"
-        fn whitelist(c: &char) -> bool {
-            match *c {
+        fn whitelist(c: char) -> bool {
+            match c {
                 'a'...'z' | 'A'...'Z' | '0'...'9' | '-' | '_' => false,
                 _ => true,
             }
         }
 
-        if let Some(c) = org_name.chars().find(whitelist) {
+        if let Some(c) = org_name.chars().find(|c| whitelist(*c)) {
             return Err(human(&format_args!(
                 "organization cannot contain special \
                  characters like {}",