Adjust crate ownership invite conditional and email subject

Author: nkanderson

src/email.rs

@@ -92,7 +92,7 @@ https://crates.io/confirm/{}",
 /// the database and the user will see the invitation when they visit
 /// https://crates.io/me/pending-invites/.
 pub fn send_owner_invite_email(email: &str, user_name: &str, crate_name: &str) {
-    let subject = "Please confirm crate ownership";
+    let subject = "Crate ownership invitation";
     let body = format!(
         "{} has invited you to become an owner of the crate {}!\n
 Please visit https://crates.io/me/pending-invites to accept or reject

src/models/krate.rs

@@ -427,10 +427,10 @@ impl Crate {
 
         match owner {
             // Users are invited and must accept before being added
-            owner @ Owner::User(_) => {
+            Owner::User(user) => {
                 let maybe_inserted = insert_into(crate_owner_invitations::table)
                     .values(&NewCrateOwnerInvitation {
-                        invited_user_id: owner.id(),
+                        invited_user_id: user.id,
                         invited_by_user_id: req_user.id,
                         crate_id: self.id,
                     })
@@ -439,21 +439,18 @@ impl Crate {
                     .optional()?;
 
                 if maybe_inserted.is_some() {
-                    if let Owner::User(user) = &owner {
-                        if let Ok(Some(email)) = user.verified_email(&conn) {
-                            email::send_owner_invite_email(
-                                &email.as_str(),
-                                &req_user.gh_login.as_str(),
-                                &self.name.as_str(),
-                            );
-                        }
+                    if let Ok(Some(email)) = user.verified_email(&conn) {
+                        email::send_owner_invite_email(
+                            &email.as_str(),
+                            &req_user.gh_login.as_str(),
+                            &self.name.as_str(),
+                        );
                     }
                 }
 
                 Ok(format!(
                     "user {} has been invited to be an owner of crate {}",
-                    owner.login(),
-                    self.name
+                    user.gh_login, self.name
                 ))
             }
             // Teams are added as owners immediately