mirage/version-download: Replace version property with relationship

Author: Turbo87

mirage/factories/version-download.js

@@ -1,8 +1,12 @@
 import { Factory } from 'ember-cli-mirage';
 
 export default Factory.extend({
-  // version
-
   date: '2019-05-21',
   downloads: i => (((i * 42) % 13) + 4) * 2345,
+
+  afterCreate(self) {
+    if (!self.versionId) {
+      throw new Error(`Missing \`version\` relationship on \`version-download:${self.date}\``);
+    }
+  },
 });

mirage/fixtures/version-downloads.js

@@ -2,16 +2,16 @@ export default [
   {
     date: '2017-02-10T00:00:00Z',
     downloads: 2,
-    version: 40905,
+    versionId: 40905,
   },
   {
     date: '2017-02-10T00:00:00Z',
     downloads: 1,
-    version: 18445,
+    versionId: 18445,
   },
   {
     date: '2017-02-11T00:00:00Z',
     downloads: 1,
-    version: 40905,
+    versionId: 40905,
   },
 ];

mirage/models/version-download.js

@@ -1,3 +1,5 @@
-import { Model } from 'ember-cli-mirage';
+import { Model, belongsTo } from 'ember-cli-mirage';
 
-export default Model.extend({});
+export default Model.extend({
+  version: belongsTo(),
+});

mirage/route-handlers/crates.js

@@ -97,7 +97,7 @@ export function register(server) {
     let version = schema.versions.findBy({ crate: crateId, num: versionNum });
     if (!version) return { errors: [{ detail: `crate \`${crateId}\` does not have a version \`${versionNum}\`` }] };
 
-    return schema.versionDownloads.where({ version: version.id });
+    return schema.versionDownloads.where({ versionId: version.id });
   });
 
   server.get('/api/v1/crates/:crate_id/owner_user', function(schema, request) {
@@ -159,7 +159,7 @@ export function register(server) {
 
     let versionDownloads = schema.versionDownloads
       .all()
-      .filter(it => crate.versions.indexOf(parseInt(it.version, 10)) !== -1);
+      .filter(it => crate.versions.indexOf(parseInt(it.versionId, 10)) !== -1);
 
     return withMeta(this.serialize(versionDownloads), { extra_downloads: crate._extra_downloads });
   });

mirage/serializers/version-download.js

@@ -0,0 +1,22 @@
+import BaseSerializer from './application';
+
+export default BaseSerializer.extend({
+  getHashForResource() {
+    let [hash, addToIncludes] = BaseSerializer.prototype.getHashForResource.apply(this, arguments);
+
+    if (Array.isArray(hash)) {
+      for (let resource of hash) {
+        this._adjust(resource);
+      }
+    } else {
+      this._adjust(hash);
+    }
+
+    return [hash, addToIncludes];
+  },
+
+  _adjust(hash) {
+    hash.version = hash.version_id;
+    delete hash.version_id;
+  },
+});

tests/mirage/crates-test.js

@@ -586,9 +586,9 @@ module('Mirage | Keywords', function(hooks) {
     test('returns a list of version downloads belonging to the specified crate version', async function(assert) {
       this.server.create('crate', { name: 'rand' });
       let version = this.server.create('version', { crate: 'rand', num: '1.0.0' });
-      this.server.create('version-download', { version: version.id, date: '2020-01-13' });
-      this.server.create('version-download', { version: version.id, date: '2020-01-14' });
-      this.server.create('version-download', { version: version.id, date: '2020-01-15' });
+      this.server.create('version-download', { version, date: '2020-01-13' });
+      this.server.create('version-download', { version, date: '2020-01-14' });
+      this.server.create('version-download', { version, date: '2020-01-15' });
 
       let response = await fetch('/api/v1/crates/rand/1.0.0/downloads');
       assert.equal(response.status, 200);
@@ -896,9 +896,9 @@ module('Mirage | Keywords', function(hooks) {
     test('returns a list of version downloads belonging to the specified crate version', async function(assert) {
       this.server.create('crate', { name: 'rand' });
       let versions = this.server.createList('version', 2, { crate: 'rand' });
-      this.server.create('version-download', { version: versions[0].id, date: '2020-01-13' });
-      this.server.create('version-download', { version: versions[1].id, date: '2020-01-14' });
-      this.server.create('version-download', { version: versions[1].id, date: '2020-01-15' });
+      this.server.create('version-download', { version: versions[0], date: '2020-01-13' });
+      this.server.create('version-download', { version: versions[1], date: '2020-01-14' });
+      this.server.create('version-download', { version: versions[1], date: '2020-01-15' });
 
       let response = await fetch('/api/v1/crates/rand/downloads');
       assert.equal(response.status, 200);