make clippy happy

Author: Skgland

src/bin/test-report.rs

@@ -79,6 +79,6 @@ impl ReportWriter for NullWriter {
 
 impl fmt::Display for NullWriter {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(f, "{:?}", self)
+        write!(f, "{self:?}")
     }
 }

src/db/mod.rs

@@ -60,7 +60,7 @@ impl<E: std::error::Error> r2d2::HandleError<E> for ErrorHandler {
         if log::log_enabled!(log::Level::Error) {
             log::error!("r2d2 error: {:?}", error);
         } else {
-            eprintln!("r2d2 error: {:?}", error);
+            eprintln!("r2d2 error: {error:?}");
         }
     }
 }

src/report/archives.rs

@@ -51,7 +51,7 @@ impl Drop for TempfileBackedBuffer {
     fn drop(&mut self) {
         unsafe {
             if let Err(e) = nix::sys::mman::munmap(self.mmap.as_ptr() as *mut _, self.mmap.len()) {
-                eprintln!("Failed to unmap temporary file: {:?}", e);
+                eprintln!("Failed to unmap temporary file: {e:?}");
             }
         }
     }

src/runner/worker.rs

@@ -258,11 +258,8 @@ impl<'a> Worker<'a> {
                         self.ex,
                         &krate,
                         tc,
-                        format!(
-                            "{}\n\nthis task or one of its parent failed: {:?}",
-                            logs, err
-                        )
-                        .as_bytes(),
+                        format!("{logs}\n\nthis task or one of its parent failed: {err:?}")
+                            .as_bytes(),
                         &result,
                         updated_version.as_ref().map(|new| (&krate, new)),
                     ) {
@@ -329,7 +326,7 @@ impl<'a> Worker<'a> {
                             self.ex,
                             &task.krate,
                             tc,
-                            format!("{}\n\n{:?}", storage, err).as_bytes(),
+                            format!("{storage}\n\n{err:?}").as_bytes(),
                             &test_result,
                             updated_version.as_ref().map(|new| (&krate, new)),
                         )?;

src/server/agents.rs

@@ -178,7 +178,6 @@ impl Agents {
             .transpose()?
             .map(|agent| agent.with_capabilities(&self.db))
             .transpose()
-            .map_err(Into::into)
     }
 
     pub fn record_heartbeat(&self, agent: &str) -> Fallible<()> {

src/server/routes/ui/experiments.rs

@@ -131,7 +131,7 @@ fn humanize(duration: Duration) -> String {
         Ok(d) => d,
         Err(_) => {
             // Don't try to make it pretty as a fallback.
-            return format!("{:?}", duration);
+            return format!("{duration:?}");
         }
     };
     if duration.as_secs() < 60 {

src/server/try_builds.rs

@@ -105,9 +105,8 @@ mod tests {
             &format!(
                 r#"
                     Try build passed.
-                    <!-- homu: {{"type": "TryBuildCompleted", "merge_sha": "{}"}} -->
-                "#,
-                COMMIT_A
+                    <!-- homu: {{"type": "TryBuildCompleted", "merge_sha": "{COMMIT_A}"}} -->
+                "#
             ),
         )
         .unwrap();

tests/minicrater/driver.rs

@@ -79,10 +79,7 @@ trait Compare {
                 "\n",
             );
             if changeset.distance != 0 {
-                eprintln!(
-                    "Difference between expected and actual reports:\n{}",
-                    changeset
-                );
+                eprintln!("Difference between expected and actual reports:\n{changeset}");
                 eprintln!("To expect the new report in the future run:");
                 eprintln!(
                     "$ cp {} {}\n",