Skip to content

Commit 06de42f

Browse files
committed
Change ignore test to test current behavior.
Include a comment about why the current behavior is wrong.
1 parent 3b7372c commit 06de42f

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/lower/test.rs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,19 +292,21 @@ fn two_blanket_impls() {
292292
}
293293

294294
#[test]
295-
#[ignore] // Ignored until we have the compat modality
295+
// FIXME This should be an error
296+
// We currently assume a closed universe always, but overlaps checking should
297+
// assume an open universe - what if a client implemented both Bar and Baz
298+
//
299+
// In other words, this should have the same behavior as the two_blanket_impls
300+
// test.
296301
fn two_blanket_impls_open_ended() {
297-
lowering_error! {
302+
lowering_success! {
298303
program {
299304
trait Foo { }
300305
trait Bar { }
301306
trait Baz { }
302307
impl<T> Foo for T where T: Bar { }
303308
impl<T> Foo for T where T: Baz { }
304309
}
305-
error_msg {
306-
"overlapping impls of trait \"Foo\""
307-
}
308310
}
309311
}
310312

0 commit comments

Comments
 (0)