Skip to content

Commit 6c9be16

Browse files
authored
Fix msrv CI: Check for --all-features (#890)
* Fix msrv CI: Check for `--all-features` and macos To make sure that enabling `parallel` feature would not require bumping msrv. Signed-off-by: Jiahao XU <[email protected]> * Use minimal-versions and fetch deps crates using stable Signed-off-by: Jiahao XU <[email protected]> * Fix fetching deps in msrv Signed-off-by: Jiahao XU <[email protected]> * Cache downlaoded crates since 1.46 is really slow in fetching Signed-off-by: Jiahao XU <[email protected]> * Skip msrv for macos-latest since newer xcode breaks 1.46 linking Signed-off-by: Jiahao XU <[email protected]> * CI: Disable fail-fast for msrv check Signed-off-by: Jiahao XU <[email protected]> * CI: Add feature to cache key of msrv Signed-off-by: Jiahao XU <[email protected]> * CI: Rm matrix features of msrv Since most of the time is spent on installing Rust, there's no point in parallelizing it. Signed-off-by: Jiahao XU <[email protected]> --------- Signed-off-by: Jiahao XU <[email protected]>
1 parent 59255ce commit 6c9be16

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

.github/workflows/main.yml

+7
Original file line numberDiff line numberDiff line change
@@ -114,16 +114,23 @@ jobs:
114114
name: MSRV
115115
runs-on: ${{ matrix.os }}
116116
strategy:
117+
fail-fast: false
117118
matrix:
118119
os: [ubuntu-latest, windows-latest]
119120
steps:
120121
- uses: actions/checkout@v4
121122
- name: Install Rust
122123
run: |
123124
rustup toolchain install 1.46.0 --no-self-update --profile minimal
125+
rustup toolchain install nightly --no-self-update --profile minimal
124126
rustup default 1.46.0
125127
shell: bash
128+
- name: Create Cargo.lock with minimal version
129+
run: cargo +nightly update -Zminimal-versions
130+
- name: Cache downloaded crates since 1.46 is really slow in fetching
131+
uses: Swatinem/rust-cache@v2
126132
- run: cargo check --lib
133+
- run: cargo check --lib --all-features
127134

128135
rustfmt:
129136
name: Rustfmt

0 commit comments

Comments
 (0)