Skip to content

test: Migrate tests/testsuite/co*.rs to snapbox #14079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jun 15, 2024
Merged

test: Migrate tests/testsuite/co*.rs to snapbox #14079

bors merged 1 commit into from
Jun 15, 2024

Conversation

@dieterplex
Copy link
Contributor

@dieterplex dieterplex commented Jun 15, 2024

Migrating files:

  • tests/testsuite/collisions.rs
    • with_stderr_does_not_contain in test collision_doc_host_target_feature_split
  • tests/testsuite/concurrent.rs
  • tests/testsuite/config.rs
  • tests/testsuite/config_cli.rs
  • tests/testsuite/config_include.rs
  • tests/testsuite/corrupt_git.rs

Testing with command SNAPSHOTS=overwrite cargo test collisions:: or so.

Part of #14039

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2024
weihanglo
weihanglo approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

tests/testsuite/collisions.rs
// two processes writing to the file at the same time.
p.cargo("build -j=1")
.with_stderr_contains(&format!("\
.with_stderr_data(&format!("\
Copy link
Member

@weihanglo weihanglo Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker.
Just call it out so we can deal with it later. See #14068 (comment)

@weihanglo
Copy link
Member

weihanglo commented Jun 15, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jun 15, 2024

📌 Commit bd451d0 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2024
@bors
Copy link
Contributor

bors commented Jun 15, 2024

⌛ Testing commit bd451d0 with merge 0feff3d...

@bors
Copy link
Contributor

bors commented Jun 15, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 0feff3d to master...

@bors bors merged commit 0feff3d into rust-lang:master Jun 15, 2024
@weihanglo weihanglo mentioned this pull request Jun 15, 2024
Closed
@bors bors mentioned this pull request Jun 15, 2024
Merged
@dieterplex dieterplex deleted the snapboxport4co branch June 16, 2024 02:18
@weihanglo weihanglo mentioned this pull request Jun 19, 2024
Merged
@rustbot rustbot added this to the 1.81.0 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dieterplex @rustbot @weihanglo @bors @ehuss