Skip to content

--host flag in search command wants registry index URL, not registry website host #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fa7ca7 opened this issue Jun 25, 2017 · 1 comment · Fixed by #4267
Closed

--host flag in search command wants registry index URL, not registry website host #4219

fa7ca7 opened this issue Jun 25, 2017 · 1 comment · Fixed by #4267
Labels
Command-search

Comments

@fa7ca7
Copy link
Contributor

fa7ca7 commented Jun 25, 2017

The issue is the same as in #3797, but relates to bin/search.
@fa7ca7 fa7ca7 mentioned this issue Jun 25, 2017
Closed
@ashleygwilliams
Copy link
Member

for people interested in taking this on, steps required would include, but may not be limited to:

  • deprecate --host
  • rename it as --index

a good example is this PR which does the same thing, but for publish #4209

(thanks for filing @dethoter! 🐶 ⭐️ 🌴 )

@natboehm natboehm mentioned this issue Jul 10, 2017
Merged
bors added a commit that referenced this issue Jul 10, 2017
@bors
Auto merge of #4267 - natboehm:add-index-flag-search, r=matklad
2b8de5d 
Replace `cargo search --host` with `cargo search --index`

This change makes the command consistent with other versions of the same flag. `cargo search --host` is still supported, as well as `cargo search --index <index> --host <host>` in case of confusion. The three commands currently supported should produce the same behavior. All instances of `--host` are currently marked as deprecated, or for reuse as mentioned in issue #4208.

Fixes #4219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Command-search
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace cargo search --host with cargo search --index natboehm/cargo
2 participants
@ashleygwilliams @fa7ca7