Skip to content

cargo-check doesn't wait for children on SIGTERM #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fuine opened this issue Apr 24, 2017 · 1 comment
Closed

cargo-check doesn't wait for children on SIGTERM #3950

fuine opened this issue Apr 24, 2017 · 1 comment

Comments

@fuine
Copy link

fuine commented Apr 24, 2017

This is a possible duplicate of #2343 and #2525. To reproduce issue cargo check in project with several dependencies, with target directory initially removed. As cargo compiles dependencies send SIGTERM to the cargo-check process. On my machine this causes the process to exit to shell with the message [1] 6350 terminated cargo check, but the messages from dependencies compilation appear, conflicting with the shell prompt. This issue is a plausible cause of the bug neomake/neomake#1216, which results in zombie processes and blocked repository. As I understand it this should not happen, and the parent process should wait for the children to finish, possibly signaling them to abort their work, but correct me if I'm wrong, as I don't know much about cargo's internals.

@alexcrichton
Copy link
Member

Thanks for the report! This is, however, intentional. Editors and IDEs that want to kill all of the processes that Cargo spawns should use setsid to place Cargo into its own process group, and then kill the process group (that's the typical way to do this on Unix).

Let me know though if you need assistance with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants