Skip to content

Redundant registry update when adding a dependency to several worksapace members #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matklad opened this issue Sep 16, 2016 · 2 comments

Comments

@matklad
Copy link
Member

matklad commented Sep 16, 2016

I have a workspace with two packages, one of which depends on regex="*". If I add regex="*" to the second member as well, I hit a registry update on the next rebuild. It is not necessary, because the existing regex dependency of the workspace will be reused.

I think the general property we want is:

  • If after an update the lock file contains the subset of the packages before the update, then we have not hit the Internet.
@matklad
Copy link
Member Author

matklad commented Sep 21, 2016

May or may not be relevant, but updated field of the RegistrySource is never used (always false).

@alexcrichton
Copy link
Member

I think this is a dupe of #2895, so closing in favor of that. Agreed a bug though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants