-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
C-bugCategory: bugCategory: bugCommand-publishS-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.regression-from-stable-to-betaRegression in beta that previously worked in stable.Regression in beta that previously worked in stable.
Description
Problem
When a tool like cargo release runs in a dry-run mode, it shouldn't be bumping version numbers. However, as of #14448, cargo publish --dry-run will fail unless the version numbers are bumped
Steps
$ git clone git@github.com:clap-rs/clap.git
$ cd clap
$ cargo +beta release major -vvvPossible Solution(s)
Revert #14448 which makes us lose out on early error reporting. However, if we view publish as plumbing with tools like cargo release handling it, make its not too bad
Skip #14448's check in dry-run mode or downgrade it to a warning. Deviating behavior between dry-run or not can be confusing and break other workflows.
Tell people to use cargo package. There are slight behavior differences though.
Notes
cargo 1.83.0-beta.2 (15fbd2f 2024-10-08)
Version
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCategory: bugCategory: bugCommand-publishS-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.regression-from-stable-to-betaRegression in beta that previously worked in stable.Regression in beta that previously worked in stable.