refactor(resolve): Calculate all states

Author: epage

src/cargo/ops/cargo_update.rs

@@ -788,12 +788,6 @@ fn report_latest(possibilities: &[IndexSummary], change: &PackageChange) -> Opti
         })
         .filter(|s| package_id.version() != s.version() && version_req.matches(s.version()))
         .max_by_key(|s| s.version());
-    if let Some(summary) = compat_ver_compat_msrv_summary {
-        let warn = style::WARN;
-        let version = summary.version();
-        let report = format!(" {warn}(available: v{version}){warn:#}");
-        return Some(report);
-    }
 
     let incompat_ver_compat_msrv_summary = possibilities
         .iter()
@@ -809,50 +803,54 @@ fn report_latest(possibilities: &[IndexSummary], change: &PackageChange) -> Opti
         })
         .filter(|s| is_latest(s.version(), package_id.version()))
         .max_by_key(|s| s.version());
-    if let Some(summary) = incompat_ver_compat_msrv_summary {
+
+    let compat_ver_summary = possibilities
+        .iter()
+        .map(|s| s.as_summary())
+        .filter(|s| package_id.version() != s.version() && version_req.matches(s.version()))
+        .max_by_key(|s| s.version());
+
+    let incompat_ver_summary = possibilities
+        .iter()
+        .map(|s| s.as_summary())
+        .filter(|s| is_latest(s.version(), package_id.version()))
+        .max_by_key(|s| s.version());
+
+    if let Some(summary) = compat_ver_compat_msrv_summary {
+        let warn = style::WARN;
+        let version = summary.version();
+        let report = format!(" {warn}(available: v{version}){warn:#}");
+        Some(report)
+    } else if let Some(summary) = incompat_ver_compat_msrv_summary {
         let warn = if change.is_transitive.unwrap_or(true) {
             Default::default()
         } else {
             style::WARN
         };
         let version = summary.version();
         let report = format!(" {warn}(available: v{version}){warn:#}");
-        return Some(report);
-    }
-
-    let compat_ver_summary = possibilities
-        .iter()
-        .map(|s| s.as_summary())
-        .filter(|s| package_id.version() != s.version() && version_req.matches(s.version()))
-        .max_by_key(|s| s.version());
-    if let Some(summary) = compat_ver_summary {
+        Some(report)
+    } else if let Some(summary) = compat_ver_summary {
         let msrv_note = summary
             .rust_version()
             .map(|rv| format!(", requires Rust {rv}"))
             .unwrap_or_default();
         let warn = style::NOP;
         let version = summary.version();
         let report = format!(" {warn}(available: v{version}{msrv_note}){warn:#}");
-        return Some(report);
-    }
-
-    let incompat_ver_summary = possibilities
-        .iter()
-        .map(|s| s.as_summary())
-        .filter(|s| is_latest(s.version(), package_id.version()))
-        .max_by_key(|s| s.version());
-    if let Some(summary) = incompat_ver_summary {
+        Some(report)
+    } else if let Some(summary) = incompat_ver_summary {
         let msrv_note = summary
             .rust_version()
             .map(|rv| format!(", requires Rust {rv}"))
             .unwrap_or_default();
         let warn = style::NOP;
         let version = summary.version();
         let report = format!(" {warn}(available: v{version}{msrv_note}){warn:#}");
-        return Some(report);
+        Some(report)
+    } else {
+        None
     }
-
-    None
 }
 
 fn is_latest(candidate: &semver::Version, current: &semver::Version) -> bool {