Skip to content

Commit df0c64e

Browse files
committed
Have Edition know what its default resolver behaviour is
1 parent e6827ee commit df0c64e

2 files changed

Lines changed: 15 additions & 10 deletions

File tree

src/cargo/core/features.rs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ use anyhow::{bail, Error};
102102
use cargo_util::ProcessBuilder;
103103
use serde::{Deserialize, Serialize};
104104

105+
use crate::core::resolver::ResolveBehavior;
105106
use crate::util::errors::CargoResult;
106107
use crate::util::{indented_lines, iter_join};
107108
use crate::Config;
@@ -242,6 +243,14 @@ impl Edition {
242243
Edition2021 => false,
243244
}
244245
}
246+
247+
pub(crate) fn default_resolve_behavior(&self) -> ResolveBehavior {
248+
if *self >= Edition::Edition2021 {
249+
ResolveBehavior::V2
250+
} else {
251+
ResolveBehavior::V1
252+
}
253+
}
245254
}
246255

247256
impl fmt::Display for Edition {

src/cargo/core/workspace.rs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use crate::core::features::Features;
1616
use crate::core::registry::PackageRegistry;
1717
use crate::core::resolver::features::CliFeatures;
1818
use crate::core::resolver::ResolveBehavior;
19-
use crate::core::{Dependency, Edition, FeatureValue, PackageId, PackageIdSpec};
19+
use crate::core::{Dependency, FeatureValue, PackageId, PackageIdSpec};
2020
use crate::core::{EitherManifest, Package, SourceId, VirtualManifest};
2121
use crate::ops;
2222
use crate::sources::{PathSource, CRATES_IO_INDEX, CRATES_IO_REGISTRY};
@@ -287,16 +287,12 @@ impl<'cfg> Workspace<'cfg> {
287287
// - If the root package specifies edition 2021, use v2.
288288
// - Otherwise, use the default v1.
289289
self.resolve_behavior = match self.root_maybe() {
290-
MaybePackage::Package(p) => p.manifest().resolve_behavior().or_else(|| {
291-
if p.manifest().edition() >= Edition::Edition2021 {
292-
Some(ResolveBehavior::V2)
293-
} else {
294-
None
295-
}
296-
}),
297-
MaybePackage::Virtual(vm) => vm.resolve_behavior(),
290+
MaybePackage::Package(p) => p
291+
.manifest()
292+
.resolve_behavior()
293+
.unwrap_or_else(|| p.manifest().edition().default_resolve_behavior()),
294+
MaybePackage::Virtual(vm) => vm.resolve_behavior().unwrap_or(ResolveBehavior::V1),
298295
}
299-
.unwrap_or(ResolveBehavior::V1);
300296
}
301297

302298
/// Returns the current package of this workspace.

0 commit comments

Comments
 (0)