You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SourceId: some git branches aren't properly serialized
This adds a failing test for #11085.
For some branch names (or tags or refs), generate_lockfile will
serialize poorly. Parsing the Cargo.lock will refer to a branch
that wasn't the intended one in Cargo.toml.
Because a branch name can contain the '#' character, the precise
reference could be corrupted through a branch/tag/ref as well.
This is because serialisation is done with a custom Display
implementation that concatenates strings as-is and is unaware
that some characters may need escaping; on the other hand,
deserialization uses url::Url::query_pairs which assumes
<https://url.spec.whatwg.org/#application/x-www-form-urlencoded>.
0 commit comments