Skip to content

Commit d99c35c

Browse files
committed
Clarify some versions
1 parent 4567826 commit d99c35c

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

src/cargo/core/source/source_id.rs

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -522,13 +522,20 @@ impl PartialOrd for SourceKind {
522522
// trait implementation is preserving the "broken" behavior. Put a different way:
523523
//
524524
// * Rust pre-1.47 sorted git deps first.
525-
// * Rust 1.47 to Rust 1.51 sorted git deps last, a breaking change that was
526-
// never noticed.
527-
// * Rust 1.52 restored the pre-1.47 behavior (without knowing it did so), and
528-
// breakage was witnessed by actual users due to difference with 1.51.
529-
// * Rust 1.52 (the source as it lives now) changed to match the 1.47-1.51
530-
// behavior, which is now considered intentionally breaking from the pre-1.47
531-
// behavior.
525+
// * Rust 1.47 to Rust 1.51 sorted git deps last, a breaking change (#8522) that
526+
// was never noticed.
527+
// * Rust 1.52 restored the pre-1.47 behavior (#9133, without knowing it did
528+
// so), and breakage was witnessed by actual users due to difference with
529+
// 1.51.
530+
// * Rust 1.52 (the source as it lives now) was fixed to match the 1.47-1.51
531+
// behavior (#9383), which is now considered intentionally breaking from the
532+
// pre-1.47 behavior.
533+
//
534+
// Note that this was all discovered when Rust 1.53 was in nightly and 1.52 was
535+
// in beta. #9133 was in both beta and nightly at the time of discovery. For
536+
// 1.52 #9383 reverted #9133, meaning 1.52 is the same as 1.51. On nightly
537+
// (1.53) #9397 was created to fix the regression introduced by #9133 relative
538+
// to the current stable (1.51).
532539
//
533540
// That's all a long winded way of saying "it's wierd that git deps hash first
534541
// and are sorted last, but it's the way it is right now". The author of this

0 commit comments

Comments
 (0)