Auto merge of #6380 - fbunt:issue-6370, r=alexcrichton

Warn if feature is called "default-features"

Fixes #6370.

I'm new to Rust and Cargo so any tips or critiques are welcome!

Author: bors

src/cargo/util/toml/mod.rs

@@ -1021,6 +1021,13 @@ impl TomlManifest {
             None => false,
         };
 
+        if summary.features().contains_key("default-features") {
+            warnings.push(
+                "`default-features = [\"..\"]` was found in [features]. \
+                Did you mean to use `default = [\"..\"]`?".to_string()
+            )
+        }
+
         let custom_metadata = project.metadata.clone();
         let mut manifest = Manifest::new(
             summary,

tests/testsuite/features.rs

@@ -1730,3 +1730,36 @@ fn feature_off_dylib() {
     // Check that building without `f1` uses a dylib without `f1`.
     p.cargo("run -p bar").run();
 }
+
+#[test]
+fn warn_if_default_features() {
+    let p = project()
+        .file(
+            "Cargo.toml",
+            r#"
+            [project]
+            name = "foo"
+            version = "0.0.1"
+            authors = []
+
+            [dependencies.bar]
+            path = "bar"
+            optional = true
+
+            [features]
+            default-features = ["bar"]
+         "#
+        ).file("src/main.rs", "fn main() {}")
+        .file("bar/Cargo.toml",&basic_manifest("bar", "0.0.1"))
+        .file("bar/src/lib.rs", "pub fn bar() {}")
+        .build();
+
+    p.cargo("build")
+        .with_stderr(
+            r#"
+[WARNING] `default-features = [".."]` was found in [features]. Did you mean to use `default = [".."]`?
+[COMPILING] foo v0.0.1 ([CWD])
+[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
+            "#.trim(),
+        ).run();
+}